Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opentelemetry-exporter-prometheus] Export PrometheusSerializer #3033

Closed
matschaffer opened this issue Jun 13, 2022 · 2 comments · Fixed by #3034
Closed

[opentelemetry-exporter-prometheus] Export PrometheusSerializer #3033

matschaffer opened this issue Jun 13, 2022 · 2 comments · Fixed by #3034

Comments

@matschaffer
Copy link
Contributor

matschaffer commented Jun 13, 2022

Is your feature request related to a problem? Please describe.

I would like to implement a PrometheusExporter that fits into the kibana routing infrastrucure. The implementation of the exporter is simple if I can reuse the PrometheusSerializer, but it's not exported from the package index.

Describe the solution you'd like

Exporting it should fix this, if it's acceptable to have as part of the public API.

Describe alternatives you've considered

For now I've cloned a slightly-modified version of the PrometheusSerializer code into my own kibana PR.

elastic/kibana@05389c3 (#133171)

@matschaffer matschaffer changed the title Export PrometheusSerializer [opentelemetry-exporter-prometheus] Export PrometheusSerializer Jun 13, 2022
@weyert
Copy link
Contributor

weyert commented Jun 13, 2022

Can’t you use the request handler that’s available on PrometheusExporter?
That’s what I am using the expose a a metrics a endpoint on my services to avoid a second http server

I am doing exporter. getMetricsRequestHandler(req, res)

@matschaffer
Copy link
Contributor Author

See #3034 (comment) for followup on above comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants