-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NodeSDK should take a serviceName prop #2799
Comments
Thoughts @open-telemetry/javascript-maintainers ? |
I completely agree. The current API to create resources in the NodeSDK module is very annoying to use, and service.name is important enough to have its own special handling. |
I agree too, is there any other required field or maybe some that are not required but strongly suggested to set that we could offer as top level config ? |
I guess whatever is here https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/resource/semantic_conventions/README.md#attributes-with-special-handling ? Which is just service.name today |
Add a convenience prop because
is imho verbose for this option which is always needed, also it requires explicitly installing
'@opentelemetry/resources'
and'@opentelemetry/semantic-conventions'
Would be added here (among other places):
opentelemetry-js/experimental/packages/opentelemetry-sdk-node/src/types.ts
Lines 28 to 42 in b756b7c
The text was updated successfully, but these errors were encountered: