Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jaeger exporter does not transform links attributes #2732

Closed
blumamir opened this issue Jan 24, 2022 · 2 comments
Closed

Jaeger exporter does not transform links attributes #2732

blumamir opened this issue Jan 24, 2022 · 2 comments
Assignees
Labels
feature-request size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Comments

@blumamir
Copy link
Member

Is your feature request related to a problem? Please describe.

Following #2718 and #2731, I noticed that the jaeger exporter does not export links attributes.

Quote from the spec:

The Link's attributes cannot be represented in Jaeger explicitly. The exporter MAY additionally convert Link(s) to span Log(s):

use Span start time as the timestamp of the Log
set Log tag event=link
set Log tags trace_id and span_id from the respective SpanContext's fields
store Link's attributes as Log tags

Describe the solution you'd like

Implement span links attributes as Logs as described in the spec.

Describe alternatives you've considered

Not to export links attributes to jaeger.

Additional context

Checked in other SDKs (Ruby, Python, Java) and none of them seems to implement this behavior. Since this is optional by the spec, not implemented in other SDKs, and does not bother anyone currently, I don't think it's urgent to do it.
Opened the issue for documentation, discussion, and for the chance that someone might want to pick this one up.

@blumamir blumamir added feature-request up-for-grabs Good for taking. Extra help will be provided by maintainers size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 24, 2022
@sudhanshu-chauhan
Copy link

@blumamir would like to take this up

@legendecas legendecas removed up-for-grabs Good for taking. Extra help will be provided by maintainers never-stale labels Oct 8, 2022
@pichlermarc
Copy link
Member

Closing this as not planned as the jaeger exporter is deprecated and Jaeger now supports OTLP out of the box.

@pichlermarc pichlermarc closed this as not planned Won't fix, can't repro, duplicate, stale Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

No branches or pull requests

5 participants