Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otlp exporters: missing some environment variables from spec in SDK #2706

Closed
blumamir opened this issue Jan 7, 2022 · 2 comments · Fixed by #2738, #2796, #2813 or #2827
Closed

otlp exporters: missing some environment variables from spec in SDK #2706

blumamir opened this issue Jan 7, 2022 · 2 comments · Fixed by #2738, #2796, #2813 or #2827
Assignees

Comments

@blumamir
Copy link
Member

blumamir commented Jan 7, 2022

Is your feature request related to a problem? Please describe.

According to the spec for otlp exporter environment variables, the following variable should be supported by the otlp exporter:

OTEL_EXPORTER_OTLP_INSECURE, OTEL_EXPORTER_OTLP_SPAN_INSECURE, OTEL_EXPORTER_OTLP_METRIC_INSECURE
OTEL_EXPORTER_OTLP_CERTIFICATE, OTEL_EXPORTER_OTLP_TRACES_CERTIFICATE, OTEL_EXPORTER_OTLP_METRICS_CERTIFICATE
OTEL_EXPORTER_OTLP_COMPRESSION, OTEL_EXPORTER_OTLP_TRACES_COMPRESSION, OTEL_EXPORTER_OTLP_METRICS_COMPRESSION
OTEL_EXPORTER_OTLP_TIMEOUT, OTEL_EXPORTER_OTLP_TRACES_TIMEOUT, OTEL_EXPORTER_OTLP_METRICS_TIMEOUT

If I am not mistaken, these exporter options are not currently being read and applied.

Describe the solution you'd like

Add the appropriate options to the 3 otlp exporters

Describe alternatives you've considered

Additional context

Not sure if the optional INSECURE options are relevant in JS:

Implementations MAY choose to not implement the insecure option if it is not required or supported by the underlying gRPC client implementation.

@dyladan
Copy link
Member

dyladan commented Jan 7, 2022

I'm pretty sure @grpc/grpc-js supports both secure and insecure modes.

@blumamir blumamir added the up-for-grabs Good for taking. Extra help will be provided by maintainers label Jan 12, 2022
@svetlanabrennan
Copy link
Contributor

I'm interested in this issue. This relates to my retry logic issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment