Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instrumentation doesn't handle relative path within modules OS independent #1990

Closed
Flarna opened this issue Mar 2, 2021 · 0 comments · Fixed by #1999
Closed

Instrumentation doesn't handle relative path within modules OS independent #1990

Flarna opened this issue Mar 2, 2021 · 0 comments · Fixed by #1999
Labels
bug Something isn't working

Comments

@Flarna
Copy link
Member

Flarna commented Mar 2, 2021

What version of OpenTelemetry are you using?

0.17.0

What version of Node are you using?

14.16.0

What did you do?

see open-telemetry/opentelemetry-js-contrib#354 (comment)

Use module relative path in an InstrumentationNodeModuleFile.

What did you expect to see?

Instrumentation should work on windows and linux.

What did you see instead?

Windows doesn't work because it uses \\ instead /.

Additional context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: fixing path of instrumentation file for different systems obecny/opentelemetry-js
1 participant
@Flarna