New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] `SpanOptions #startTime` is of type `TimeInput` #1793

Closed

dyladan opened this issue Jan 6, 2021 · 0 comments · Fixed by #1815

Member

dyladan commented Jan 6, 2021

There is an inconsistency between tracer.startSpan() and span.end() regarding timestamps passed by user:

SpanOptions #startTime is of type number
span.end() accepts TimeInput which is HrTime | number | Date

Originally posted by @Flarna in #1765 (comment)

The text was updated successfully, but these errors were encountered:

dyladan added the API label

dyladan added the release:required-for-ga label

dyladan mentioned this issue

chore: change SpanOptions startTime to TimeInput #1815

Merged

dyladan closed this as completed in #1815

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment