Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove retryable failure from exporter.export #1629

Closed
dyladan opened this issue Oct 28, 2020 · 2 comments
Closed

Remove retryable failure from exporter.export #1629

dyladan opened this issue Oct 28, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@dyladan
Copy link
Member

dyladan commented Oct 28, 2020

According to the spec for Exporter.ExportBatch, the result returned is no longer SUCCESS, FAILED_RETRYABLE, FAILED_NONRETRYABLE, but is just SUCCESS, or FAILURE. The new spec states that all retry logic should be handled by the exporter.

Originally discovered here: #1622 (comment)
@dyladan dyladan added bug Something isn't working release:required-for-ga labels Oct 28, 2020
@vmarchaud
Copy link
Member

i've already opened an issue there: #1569, do you want to close the old one ?

@dyladan
Copy link
Member Author

dyladan commented Oct 28, 2020

Ah. Sorry. Closed as duplicate

@dyladan dyladan closed this as completed Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dyladan @vmarchaud