Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single header B3 support #1542

Closed
mwear opened this issue Sep 16, 2020 · 2 comments · Fixed by #1560
Closed

Single header B3 support #1542

mwear opened this issue Sep 16, 2020 · 2 comments · Fixed by #1560
Assignees

Comments

@mwear
Copy link
Member

mwear commented Sep 16, 2020

Is your feature request related to a problem? Please describe.

OpenTelemetry JS does not have single header support for B3. Other languages do:

This is likely to become a requirement via: open-telemetry/opentelemetry-specification#960

Describe the solution you'd like

The extract method for the B3 propagator should handle the single header b3 case.

@mwear mwear self-assigned this Sep 16, 2020
@mwear
Copy link
Member Author

mwear commented Sep 16, 2020

I can start working on this. Let me know if there are any concerns about the idea, or approach.

@mwear
Copy link
Member Author

mwear commented Sep 25, 2020

As I was digging into this, I realized there is quite a bit of variation in how different implementations handle the b3 trace flags and parent span id propagation. I opened this issue: open-telemetry/opentelemetry-specification#1004 as a result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant