Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement capturing error type/msg/stacktrace as events per spec #1322

Closed
ericmustin opened this issue Jul 16, 2020 · 2 comments · Fixed by #1372
Closed

Implement capturing error type/msg/stacktrace as events per spec #1322

ericmustin opened this issue Jul 16, 2020 · 2 comments · Fixed by #1372
Assignees

Comments

@ericmustin
Copy link

👋 Hello all, just adding a quick issue here surfacing this Spec PR for adding error/exception reporting as events that include metadata for the error type, message, and stacktrace. open-telemetry/opentelemetry-specification#697

I think implementing this in opentelemetry-js could add value to the traces being generated, as currently error type and stacktrace aren't being explicitly captured (though it does look like some instrumentations set the error_name attribute).

Spec PR: open-telemetry/opentelemetry-specification#697

Was asked to make an issue on this by @obecny during discussion of a vendor exporter pr here #1316

@vmarchaud vmarchaud added release:required-for-ga up-for-grabs Good for taking. Extra help will be provided by maintainers labels Jul 17, 2020
@vmarchaud
Copy link
Member

If i'm correct this is still being discussed a little bit, might be better to wait the merge before trying to implement anything

@dyladan
Copy link
Member

dyladan commented Jul 17, 2020

Looks like it merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants