From 0789ae9dc3db5022bc3e25e28033349cc58dd229 Mon Sep 17 00:00:00 2001 From: Dobes Vandermeer Date: Wed, 20 Jan 2021 10:31:47 -0800 Subject: [PATCH] fix: move semantic-conventions to regular dependencies These dependencies are imported at runtime but were only declared as devDependencies. This causes problems for people using these packages with yarn pnp. --- plugins/node/opentelemetry-plugin-ioredis/package.json | 2 +- plugins/node/opentelemetry-plugin-mongodb/package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/node/opentelemetry-plugin-ioredis/package.json b/plugins/node/opentelemetry-plugin-ioredis/package.json index 224bf9b943..a0532c587e 100644 --- a/plugins/node/opentelemetry-plugin-ioredis/package.json +++ b/plugins/node/opentelemetry-plugin-ioredis/package.json @@ -46,7 +46,6 @@ "devDependencies": { "@opentelemetry/context-async-hooks": "^0.14.0", "@opentelemetry/node": "^0.14.0", - "@opentelemetry/semantic-conventions": "^0.14.0", "@opentelemetry/test-utils": "^0.12.1", "@opentelemetry/tracing": "^0.14.0", "@types/ioredis": "4.17.3", @@ -69,6 +68,7 @@ "dependencies": { "@opentelemetry/api": "^0.14.0", "@opentelemetry/core": "^0.14.0", + "@opentelemetry/semantic-conventions": "^0.14.0", "shimmer": "^1.2.1" } } diff --git a/plugins/node/opentelemetry-plugin-mongodb/package.json b/plugins/node/opentelemetry-plugin-mongodb/package.json index 6a67fe26f5..0cc5f907dd 100644 --- a/plugins/node/opentelemetry-plugin-mongodb/package.json +++ b/plugins/node/opentelemetry-plugin-mongodb/package.json @@ -43,7 +43,6 @@ "devDependencies": { "@opentelemetry/context-async-hooks": "^0.14.0", "@opentelemetry/node": "^0.14.0", - "@opentelemetry/semantic-conventions": "^0.14.0", "@opentelemetry/tracing": "^0.14.0", "@types/mocha": "7.0.2", "@types/mongodb": "3.5.25", @@ -64,6 +63,7 @@ "dependencies": { "@opentelemetry/api": "^0.14.0", "@opentelemetry/core": "^0.14.0", + "@opentelemetry/semantic-conventions": "^0.14.0", "shimmer": "^1.2.1" } }