-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update test-all-versions configs to test fewer package versions #2464
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d7e29e1
chore: update test-all-versions configs to test fewer package versions
trentm 15c40db
instr-restify: bump min-supported from 4.0.0 to 4.1.0 because of some…
trentm 0a3e617
instr-nestjs-core TAV testing: fix for @nestjs/core@9 and 10
trentm f7929bf
instr-pg: drop setting IN_TAV which stopped being used in #1393
trentm c52e262
instr-aws-sdk TAV tests: skip bad releases of client-sqs
trentm 898b3e1
pg test failure fixes:
trentm 6bb7fd6
testing aws-sdk versions: avoid [3.363.0, 3.377.0] of all @aws-sdk/c…
trentm ffbaa5e
Merge branch 'main' into tm-reduce-tav
trentm 51137f7
nestjs testing: NestJS 10 requires Node.js v16 or later.
trentm 52a24f1
Merge branch 'main' into tm-reduce-tav
trentm 75b755e
Merge branch 'main' into tm-reduce-tav
pichlermarc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,6 @@ | ||
'amqplib': | ||
versions: ">=0.5.5" | ||
amqplib: | ||
versions: | ||
include: ">=0.5.5" | ||
mode: latest-minors | ||
commands: | ||
- yarn test | ||
- npm test |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,11 @@ | ||
'@cucumber/cucumber': | ||
- versions: '^8.0.0 || ^9.0.0' | ||
- versions: | ||
include: '^8.0.0 || ^9.0.0' | ||
mode: latest-minors | ||
node: '>=14' | ||
commands: npm test | ||
- versions: '^10.0.0' | ||
- versions: | ||
include: '^10.0.0' | ||
mode: latest-minors | ||
node: '>=18' | ||
commands: npm test |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,6 @@ | ||
dataloader: | ||
# Testing ^2.0.0 covers about 90% of the downloaded versions | ||
versions: "^2.0.0" | ||
versions: | ||
include: "^2.0.0" | ||
mode: latest-minors | ||
commands: npm run test |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,6 @@ | ||
'lru-memoizer': | ||
versions: ">=1.3 <3" | ||
versions: | ||
include: ">=1.3 <3" | ||
mode: latest-minors | ||
commands: | ||
- npm test |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 15 additions & 6 deletions
21
plugins/node/opentelemetry-instrumentation-aws-sdk/.tav.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,28 @@ | ||
"aws-sdk": | ||
# A small subset of releases in the range [2.308.0, 3) to reduce testing time. | ||
versions: "2.308.0 || 2.556.0 || 2.801.0 || 2.1049.0 || 2.1297.0 || 2.1546.0 || >=2.1548.0" | ||
versions: | ||
include: "^2.308.0" | ||
mode: max-7 | ||
commands: | ||
- npm run test | ||
|
||
# Versions [3.363.0, 3.377.0] of all @aws-sdk/client-* were bad releases. See: | ||
# - https://github.com/open-telemetry/opentelemetry-js-contrib/pull/2464#issuecomment-2403652552 | ||
# - https://github.com/open-telemetry/opentelemetry-js-contrib/issues/1828#issuecomment-1834276719 | ||
|
||
"@aws-sdk/client-s3": | ||
# A small subset of releases in the range [3.6.1, 4) to reduce testing time. | ||
# - 3.377.0 was a bad release (see issue #1828). | ||
# - 3.529.0 was missing the fast-xml-parser dependency (https://github.com/aws/aws-sdk-js-v3/releases/tag/v3.529.1) | ||
versions: "3.6.1 || 3.55.0 || 3.180.0 || 3.289.0 || 3.385.0 || 3.498.0 || >=3.529.1" | ||
versions: | ||
include: "^3.6.1" | ||
exclude: "3.529.0 || >=3.363.0 <=3.377.0" | ||
mode: "max-7" | ||
commands: | ||
- npm run test | ||
|
||
"@aws-sdk/client-sqs": | ||
# A small subset of releases in the range [3.24.0, 4) to reduce testing time. | ||
versions: "3.24.0 || 3.94.0 || 3.202.0 || 3.296.0 || 3.388.0 || 3.496.0 || >=3.503.1" | ||
versions: | ||
include: "^3.24.0" | ||
exclude: ">=3.363.0 <=3.377.0" | ||
mode: "max-7" | ||
commands: | ||
- npm run test |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,6 @@ | ||
bunyan: | ||
# Testing ^1.8.12 covers at least 95% of the downloaded versions | ||
versions: "^1.8.12" | ||
versions: | ||
include: "^1.8.12" | ||
mode: latest-minors | ||
commands: npm run test |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
express: | ||
- versions: "^4.16.2" | ||
- versions: | ||
include: "^4.16.2" | ||
mode: latest-minors | ||
commands: npm run test |
10 changes: 6 additions & 4 deletions
10
plugins/node/opentelemetry-instrumentation-fastify/.tav.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,11 @@ | ||
"fastify": | ||
# Sanity check the first 4.x release, instead of all releases, plus recent | ||
# releases. | ||
- versions: "4.0.0 || >=4.24.3 <5" | ||
- versions: | ||
include: "^4.0.0" | ||
mode: max-7 | ||
commands: npm run test | ||
- versions: ">=5 <6" | ||
- versions: | ||
include: ">=5 <6" | ||
mode: max-7 | ||
commands: npm run test | ||
peerDependencies: "@fastify/[email protected]" | ||
node: '>=20' | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
graphql: | ||
# Taking a sample from the most downloaded versions in the range "14 || 15 || 16" | ||
versions: "16.4.0 || 16.3.0 || 16.2.0 || 16.0.0 || ^15.8.0 || 15.7.2 || 15.6.1 || 15.6.0 || 15.5.3 || 15.5.1 || 15.5.0 || 15.4.0 || 15.3.0 || ^14.7.0 || 14.6.0 || 14.5.8 || 14.0.0" | ||
versions: | ||
include: "14 || 15 || 16" | ||
mode: max-7 | ||
commands: npm run test |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,17 @@ | ||
"@hapi/hapi": | ||
- versions: "^19.2.0 || ^18.4.1 || ^17.9.0" | ||
- versions: | ||
include: "^19.2.0 || ^18.4.1 || ^17.9.0" | ||
mode: latest-minors | ||
node: ">=14 <16" | ||
commands: npm test | ||
- versions: "^20.3.0" | ||
- versions: | ||
include: "^20.3.0" | ||
mode: latest-minors | ||
node: ">=14" | ||
commands: npm test | ||
- versions: "^21.3.3" | ||
- versions: | ||
include: "^21.3.3" | ||
mode: latest-minors | ||
node: ">=14.15.0" | ||
commands: npm test | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,7 @@ | ||
ioredis: | ||
# Ignoring v4.19.0. Tests never ends. Caused by https://github.com/luin/ioredis/pull/1219 | ||
versions: "^2.5.0 || ^3.2.2 || 4.14.1 || 4.16.3 || 4.17.3 || 4.18.0 || 4.19.2 || 4.19.4 || 4.22.0 || 4.24.5 || 4.26.0 || 4.27.11 || ^4.28.5 || 5.0.6 || 5.2.6 || ^5.3.2" | ||
versions: | ||
include: '>=2.0.0 <6' | ||
exclude: '4.19.0' | ||
mode: max-7 | ||
commands: npm run test |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,12 @@ | ||
"@koa/router": | ||
versions: "8.0.8 || 9.4.0 || 10.0.0 || 10.1.1 || 11.0.1 || >=12.0.0" | ||
versions: | ||
include: ">=8.0.0" | ||
mode: latest-minors | ||
commands: npm run test | ||
|
||
koa: | ||
# Testing ^2.7.0 covers at least 97% of the downloaded koa versions | ||
versions: "^2.7.0" | ||
versions: | ||
include: "^2.7.0" | ||
mode: latest-minors | ||
commands: npm run test |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,8 @@ | ||
mysql2: | ||
- versions: <4 >=3.2.0 || 3.1.0 || 3.0.0 | ||
commands: npm run test | ||
|
||
- versions: <3 >=2.3.2 || 2.3.0 || 2.2.5 || 2.1.0 | ||
# Skip 2.3.3 which installs types from git which takes 10m on it's own | ||
commands: npm run test | ||
|
||
- versions: 1.4.2 || 1.5.3 || 1.6.4 || 1.6.5 || 1.7.0 | ||
versions: | ||
include: ">=1.4.2 <4" | ||
# Skip v1.6.2, which is broken | ||
# Skip 2.3.3 which installs types from git which takes 10m on it's own | ||
exclude: "1.6.2 || 2.3.3" | ||
mode: latest-minors | ||
commands: npm run test |
35 changes: 26 additions & 9 deletions
35
plugins/node/opentelemetry-instrumentation-nestjs-core/.tav.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,27 +1,44 @@ | ||
"@nestjs/core": | ||
- versions: "^8.2.0 || 8.1.2 || 8.1.1 || 8.0.11 || 8.0.9 || 8.0.6" | ||
- versions: | ||
include: ">=10.0.0 <11" | ||
mode: latest-minors | ||
# NestJS 10 requires Node.js v16 or later. | ||
# https://docs.nestjs.com/migration-guide#dropping-support-for-nodejs-v12 | ||
node: ">=16" | ||
peerDependencies: | ||
- "@nestjs/common@^10.0.0" | ||
- "rxjs@^7.1.0" | ||
commands: npm run test | ||
|
||
- versions: | ||
include: ">=9.0.0 <10" | ||
mode: latest-minors | ||
peerDependencies: | ||
- "@nestjs/common@^9.0.0" | ||
- "rxjs@^7.1.0" | ||
commands: npm run test | ||
|
||
- versions: | ||
include: ">=8.0.0 <9" | ||
mode: latest-minors | ||
peerDependencies: | ||
- "@nestjs/common@^8.0.0" | ||
- "@nestjs/microservices@^8.0.0" | ||
- "@nestjs/platform-express@^8.0.0" | ||
- "@nestjs/websockets@^8.0.0" | ||
- "rxjs@^7.1.0" | ||
commands: npm run test | ||
|
||
- versions: "^7.6.17 || 7.6.15 || 7.6.13 || 7.6.12" | ||
- versions: | ||
# We *could* test all 7.x "latest-minors", but the latest 7.x release was | ||
# 2021, so let's just test the latest. | ||
include: "^7.6.18" | ||
peerDependencies: | ||
- "@nestjs/common@^7.0.0" | ||
- "@nestjs/microservices@^7.0.0" | ||
- "@nestjs/platform-express@^7.0.0" | ||
- "@nestjs/websockets@^7.0.0" | ||
- "rxjs@^6.0.0" | ||
commands: npm run test | ||
|
||
- versions: "6.11.11" | ||
peerDependencies: | ||
- "@nestjs/common@^6.0.0" | ||
- "@nestjs/microservices@^6.0.0" | ||
- "@nestjs/platform-express@^6.0.0" | ||
- "@nestjs/websockets@^6.0.0" | ||
- "rxjs@^6.0.0" | ||
commands: npm run test |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
78 changes: 0 additions & 78 deletions
78
plugins/node/opentelemetry-instrumentation-nestjs-core/scripts/test-all-versions
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
pg: | ||
# a sample from supported versions | ||
- versions: "8.5.1 || 8.6.0 || 8.7.1" | ||
versions: | ||
include: '>=8.0.3 <9' | ||
mode: max-7 | ||
peerDependencies: pg-pool@^3 | ||
commands: npm run test |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL that this mode exists. Nice. 👍