From 886be5f689312bf1a0968340de15ee6e61621be8 Mon Sep 17 00:00:00 2001 From: Rauno Viskus Date: Wed, 22 Jun 2022 12:23:42 +0300 Subject: [PATCH 01/10] chore: remove node 8 and 10 from CI --- .github/workflows/test-all-versions.yml | 19 +------------------ .github/workflows/unit-test.yml | 16 +--------------- 2 files changed, 2 insertions(+), 33 deletions(-) diff --git a/.github/workflows/test-all-versions.yml b/.github/workflows/test-all-versions.yml index a76af8e18f..cee519a701 100644 --- a/.github/workflows/test-all-versions.yml +++ b/.github/workflows/test-all-versions.yml @@ -15,24 +15,7 @@ jobs: strategy: fail-fast: false matrix: - node: ["8", "10", "12", "14", "16"] - include: - - node: "8" - lerna-extra-args: >- - --ignore @opentelemetry/instrumentation-aws-sdk - --ignore @opentelemetry/instrumentation-pino - --ignore @opentelemetry/instrumentation-tedious - --ignore @opentelemetry/instrumentation-amqplib - --ignore @opentelemetry/instrumentation-mongodb - --ignore @opentelemetry/instrumentation-redis-4 - --ignore @opentelemetry/instrumentation-hapi - - node: "10" - lerna-extra-args: >- - --ignore @opentelemetry/instrumentation-aws-sdk - --ignore @opentelemetry/instrumentation-pino - --ignore @opentelemetry/instrumentation-mongodb - --ignore @opentelemetry/instrumentation-redis-4 - --ignore @opentelemetry/instrumentation-hapi + node: ["12", "14", "16"] runs-on: ubuntu-latest services: memcached: diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml index edb8cb92fd..0114bb09e8 100644 --- a/.github/workflows/unit-test.yml +++ b/.github/workflows/unit-test.yml @@ -9,22 +9,8 @@ jobs: strategy: fail-fast: false matrix: - node: ["8", "10", "12", "14", "16"] + node: ["12", "14", "16"] include: - - node: "8" - lerna-extra-args: >- - --ignore @opentelemetry/instrumentation-aws-sdk - --ignore @opentelemetry/instrumentation-pino - --ignore @opentelemetry/instrumentation-tedious - --ignore @opentelemetry/instrumentation-amqplib - --ignore @opentelemetry/instrumentation-redis-4 - --ignore @opentelemetry/instrumentation-hapi - - node: "10" - lerna-extra-args: >- - --ignore @opentelemetry/instrumentation-aws-sdk - --ignore @opentelemetry/instrumentation-pino - --ignore @opentelemetry/instrumentation-redis-4 - --ignore @opentelemetry/instrumentation-hapi - node: "12" lerna-extra-args: >- --ignore @opentelemetry/instrumentation-redis-4 From 8dbb9dc127357d96170eb7fd9ffd8c5edfe1fd22 Mon Sep 17 00:00:00 2001 From: Rauno Viskus Date: Wed, 22 Jun 2022 13:12:54 +0300 Subject: [PATCH 02/10] chore: update engines --- .../opentelemetry-browser-extension-autoinjection/package.json | 2 +- .../opentelemetry-resource-detector-alibaba-cloud/package.json | 2 +- detectors/node/opentelemetry-resource-detector-aws/package.json | 2 +- .../node/opentelemetry-resource-detector-docker/package.json | 2 +- detectors/node/opentelemetry-resource-detector-gcp/package.json | 2 +- .../node/opentelemetry-resource-detector-github/package.json | 2 +- metapackages/auto-instrumentations-node/package.json | 2 +- metapackages/auto-instrumentations-web/package.json | 2 +- packages/opentelemetry-host-metrics/package.json | 2 +- packages/opentelemetry-id-generator-aws-xray/package.json | 2 +- packages/opentelemetry-propagation-utils/package.json | 2 +- packages/opentelemetry-test-utils/package.json | 2 +- plugins/node/instrumentation-amqplib/package.json | 2 +- plugins/node/instrumentation-fs/package.json | 2 +- plugins/node/instrumentation-lru-memoizer/package.json | 2 +- plugins/node/instrumentation-tedious/package.json | 2 +- .../node/opentelemetry-instrumentation-aws-lambda/package.json | 2 +- plugins/node/opentelemetry-instrumentation-bunyan/package.json | 2 +- .../node/opentelemetry-instrumentation-cassandra/package.json | 2 +- plugins/node/opentelemetry-instrumentation-connect/package.json | 2 +- plugins/node/opentelemetry-instrumentation-dns/package.json | 2 +- .../opentelemetry-instrumentation-express/examples/package.json | 2 +- plugins/node/opentelemetry-instrumentation-express/package.json | 2 +- plugins/node/opentelemetry-instrumentation-fastify/package.json | 2 +- .../opentelemetry-instrumentation-generic-pool/package.json | 2 +- plugins/node/opentelemetry-instrumentation-graphql/package.json | 2 +- plugins/node/opentelemetry-instrumentation-hapi/package.json | 2 +- plugins/node/opentelemetry-instrumentation-ioredis/package.json | 2 +- plugins/node/opentelemetry-instrumentation-knex/package.json | 2 +- plugins/node/opentelemetry-instrumentation-koa/package.json | 2 +- .../node/opentelemetry-instrumentation-memcached/package.json | 2 +- plugins/node/opentelemetry-instrumentation-mysql/package.json | 2 +- plugins/node/opentelemetry-instrumentation-mysql2/package.json | 2 +- .../node/opentelemetry-instrumentation-nestjs-core/package.json | 2 +- plugins/node/opentelemetry-instrumentation-net/package.json | 2 +- plugins/node/opentelemetry-instrumentation-pg/package.json | 2 +- plugins/node/opentelemetry-instrumentation-redis/package.json | 2 +- plugins/node/opentelemetry-instrumentation-restify/package.json | 2 +- plugins/node/opentelemetry-instrumentation-router/package.json | 2 +- plugins/node/opentelemetry-instrumentation-winston/package.json | 2 +- .../opentelemetry-instrumentation-document-load/package.json | 2 +- .../web/opentelemetry-instrumentation-long-task/package.json | 2 +- .../opentelemetry-instrumentation-user-interaction/package.json | 2 +- plugins/web/opentelemetry-plugin-react-load/package.json | 2 +- propagators/opentelemetry-propagator-aws-xray/package.json | 2 +- .../opentelemetry-propagator-grpc-census-binary/package.json | 2 +- propagators/opentelemetry-propagator-ot-trace/package.json | 2 +- 47 files changed, 47 insertions(+), 47 deletions(-) diff --git a/archive/opentelemetry-browser-extension-autoinjection/package.json b/archive/opentelemetry-browser-extension-autoinjection/package.json index 7876d7c0fc..b4c7dafb2a 100644 --- a/archive/opentelemetry-browser-extension-autoinjection/package.json +++ b/archive/opentelemetry-browser-extension-autoinjection/package.json @@ -23,7 +23,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=8.12.0" + "node": ">=12.0.0" }, "peerDependencies": { "@opentelemetry/api": "^1.0.0" diff --git a/detectors/node/opentelemetry-resource-detector-alibaba-cloud/package.json b/detectors/node/opentelemetry-resource-detector-alibaba-cloud/package.json index 81be104b63..341b90548f 100644 --- a/detectors/node/opentelemetry-resource-detector-alibaba-cloud/package.json +++ b/detectors/node/opentelemetry-resource-detector-alibaba-cloud/package.json @@ -28,7 +28,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=8.12.0" + "node": ">=12.0.0" }, "files": [ "build/src/**/*.js", diff --git a/detectors/node/opentelemetry-resource-detector-aws/package.json b/detectors/node/opentelemetry-resource-detector-aws/package.json index 7d97f9d57f..5c8b7252a6 100644 --- a/detectors/node/opentelemetry-resource-detector-aws/package.json +++ b/detectors/node/opentelemetry-resource-detector-aws/package.json @@ -27,7 +27,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=8.12.0" + "node": ">=12.0.0" }, "files": [ "build/src/**/*.js", diff --git a/detectors/node/opentelemetry-resource-detector-docker/package.json b/detectors/node/opentelemetry-resource-detector-docker/package.json index f87649c2e2..f3f3a102c9 100644 --- a/detectors/node/opentelemetry-resource-detector-docker/package.json +++ b/detectors/node/opentelemetry-resource-detector-docker/package.json @@ -22,7 +22,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=8.12.0" + "node": ">=12.0.0" }, "files": [ "build/src/**/*.js", diff --git a/detectors/node/opentelemetry-resource-detector-gcp/package.json b/detectors/node/opentelemetry-resource-detector-gcp/package.json index c3dcea6490..ebb5b8485b 100644 --- a/detectors/node/opentelemetry-resource-detector-gcp/package.json +++ b/detectors/node/opentelemetry-resource-detector-gcp/package.json @@ -27,7 +27,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=10.0.0" + "node": ">=12.0.0" }, "files": [ "build/src/**/*.js", diff --git a/detectors/node/opentelemetry-resource-detector-github/package.json b/detectors/node/opentelemetry-resource-detector-github/package.json index eca25d526f..c1df6cfb7c 100644 --- a/detectors/node/opentelemetry-resource-detector-github/package.json +++ b/detectors/node/opentelemetry-resource-detector-github/package.json @@ -28,7 +28,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=8.12.0" + "node": ">=12.0.0" }, "files": [ "build/src/**/*.js", diff --git a/metapackages/auto-instrumentations-node/package.json b/metapackages/auto-instrumentations-node/package.json index 02a8abfcfd..7c5e81891d 100644 --- a/metapackages/auto-instrumentations-node/package.json +++ b/metapackages/auto-instrumentations-node/package.json @@ -6,7 +6,7 @@ "homepage": "https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/metapackages/auto-instrumentations-node#readme", "license": "Apache-2.0", "engines": { - "node": ">=8.12.0" + "node": ">=12.0.0" }, "publishConfig": { "access": "public" diff --git a/metapackages/auto-instrumentations-web/package.json b/metapackages/auto-instrumentations-web/package.json index be65e2f50c..571db8831d 100644 --- a/metapackages/auto-instrumentations-web/package.json +++ b/metapackages/auto-instrumentations-web/package.json @@ -6,7 +6,7 @@ "homepage": "https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/metapackages/auto-instrumentations-web#readme", "license": "Apache-2.0", "engines": { - "node": ">=8.12.0" + "node": ">=12.0.0" }, "publishConfig": { "access": "public" diff --git a/packages/opentelemetry-host-metrics/package.json b/packages/opentelemetry-host-metrics/package.json index f65d4e6e5a..f65d90a7a4 100644 --- a/packages/opentelemetry-host-metrics/package.json +++ b/packages/opentelemetry-host-metrics/package.json @@ -29,7 +29,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=8.12.0" + "node": ">=12.0.0" }, "files": [ "build/src/**/*.js", diff --git a/packages/opentelemetry-id-generator-aws-xray/package.json b/packages/opentelemetry-id-generator-aws-xray/package.json index b66b039c00..904455dc1b 100644 --- a/packages/opentelemetry-id-generator-aws-xray/package.json +++ b/packages/opentelemetry-id-generator-aws-xray/package.json @@ -37,7 +37,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=8.12.0" + "node": ">=12.0.0" }, "files": [ "build/esm/**/*.js", diff --git a/packages/opentelemetry-propagation-utils/package.json b/packages/opentelemetry-propagation-utils/package.json index baf047082b..ec538e40c0 100644 --- a/packages/opentelemetry-propagation-utils/package.json +++ b/packages/opentelemetry-propagation-utils/package.json @@ -32,7 +32,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=8.12.0" + "node": ">=12.0.0" }, "bugs": { "url": "https://github.com/open-telemetry/opentelemetry-js-contrib/issues" diff --git a/packages/opentelemetry-test-utils/package.json b/packages/opentelemetry-test-utils/package.json index 4ef0b22239..fd0e3e988e 100644 --- a/packages/opentelemetry-test-utils/package.json +++ b/packages/opentelemetry-test-utils/package.json @@ -31,7 +31,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=8.12.0" + "node": ">=12.0.0" }, "bugs": { "url": "https://github.com/open-telemetry/opentelemetry-js-contrib/issues" diff --git a/plugins/node/instrumentation-amqplib/package.json b/plugins/node/instrumentation-amqplib/package.json index 0b78b79876..e9873da13c 100644 --- a/plugins/node/instrumentation-amqplib/package.json +++ b/plugins/node/instrumentation-amqplib/package.json @@ -70,6 +70,6 @@ "typescript": "4.3.5" }, "engines": { - "node": ">=10.0.0" + "node": ">=12.0.0" } } diff --git a/plugins/node/instrumentation-fs/package.json b/plugins/node/instrumentation-fs/package.json index 6582902f98..74aee1c633 100644 --- a/plugins/node/instrumentation-fs/package.json +++ b/plugins/node/instrumentation-fs/package.json @@ -28,7 +28,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=8.12.0" + "node": ">=12.0.0" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/instrumentation-lru-memoizer/package.json b/plugins/node/instrumentation-lru-memoizer/package.json index 3713019d42..94f7dd844f 100644 --- a/plugins/node/instrumentation-lru-memoizer/package.json +++ b/plugins/node/instrumentation-lru-memoizer/package.json @@ -28,7 +28,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=8.12.0" + "node": ">=12.0.0" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/instrumentation-tedious/package.json b/plugins/node/instrumentation-tedious/package.json index 0610b03a63..c3df836e83 100644 --- a/plugins/node/instrumentation-tedious/package.json +++ b/plugins/node/instrumentation-tedious/package.json @@ -33,7 +33,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=10.0.0" + "node": ">=12.0.0" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-aws-lambda/package.json b/plugins/node/opentelemetry-instrumentation-aws-lambda/package.json index 88c020953d..a27c22b5cc 100644 --- a/plugins/node/opentelemetry-instrumentation-aws-lambda/package.json +++ b/plugins/node/opentelemetry-instrumentation-aws-lambda/package.json @@ -28,7 +28,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=8.12.0" + "node": ">=12.0.0" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-bunyan/package.json b/plugins/node/opentelemetry-instrumentation-bunyan/package.json index 1a712c9b0f..3564cdaacd 100644 --- a/plugins/node/opentelemetry-instrumentation-bunyan/package.json +++ b/plugins/node/opentelemetry-instrumentation-bunyan/package.json @@ -30,7 +30,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=8.12.0" + "node": ">=12.0.0" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-cassandra/package.json b/plugins/node/opentelemetry-instrumentation-cassandra/package.json index 14c888b785..100a8fd754 100644 --- a/plugins/node/opentelemetry-instrumentation-cassandra/package.json +++ b/plugins/node/opentelemetry-instrumentation-cassandra/package.json @@ -29,7 +29,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=8.12.0" + "node": ">=12.0.0" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-connect/package.json b/plugins/node/opentelemetry-instrumentation-connect/package.json index dcc39e4b4c..39e0efab43 100644 --- a/plugins/node/opentelemetry-instrumentation-connect/package.json +++ b/plugins/node/opentelemetry-instrumentation-connect/package.json @@ -28,7 +28,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=8.12.0" + "node": ">=12.0.0" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-dns/package.json b/plugins/node/opentelemetry-instrumentation-dns/package.json index 5f6a8ec7b6..f5a7aaf693 100644 --- a/plugins/node/opentelemetry-instrumentation-dns/package.json +++ b/plugins/node/opentelemetry-instrumentation-dns/package.json @@ -28,7 +28,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=8.12.0" + "node": ">=12.0.0" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-express/examples/package.json b/plugins/node/opentelemetry-instrumentation-express/examples/package.json index 1003b37ebe..ef3a3bf4cc 100644 --- a/plugins/node/opentelemetry-instrumentation-express/examples/package.json +++ b/plugins/node/opentelemetry-instrumentation-express/examples/package.json @@ -21,7 +21,7 @@ "tracing" ], "engines": { - "node": ">=8.12.0" + "node": ">=12.0.0" }, "author": "OpenTelemetry Authors", "license": "Apache-2.0", diff --git a/plugins/node/opentelemetry-instrumentation-express/package.json b/plugins/node/opentelemetry-instrumentation-express/package.json index 656dc1cf31..8ed017128a 100644 --- a/plugins/node/opentelemetry-instrumentation-express/package.json +++ b/plugins/node/opentelemetry-instrumentation-express/package.json @@ -31,7 +31,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=8.12.0" + "node": ">=12.0.0" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-fastify/package.json b/plugins/node/opentelemetry-instrumentation-fastify/package.json index 006e18f0b7..3a6866c5e1 100644 --- a/plugins/node/opentelemetry-instrumentation-fastify/package.json +++ b/plugins/node/opentelemetry-instrumentation-fastify/package.json @@ -28,7 +28,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=8.12.0" + "node": ">=12.0.0" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-generic-pool/package.json b/plugins/node/opentelemetry-instrumentation-generic-pool/package.json index fe8ae8ab90..418ccb9393 100644 --- a/plugins/node/opentelemetry-instrumentation-generic-pool/package.json +++ b/plugins/node/opentelemetry-instrumentation-generic-pool/package.json @@ -28,7 +28,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=8.12.0" + "node": ">=12.0.0" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-graphql/package.json b/plugins/node/opentelemetry-instrumentation-graphql/package.json index cc9400914f..8d98082743 100644 --- a/plugins/node/opentelemetry-instrumentation-graphql/package.json +++ b/plugins/node/opentelemetry-instrumentation-graphql/package.json @@ -30,7 +30,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=8.12.0" + "node": ">=12.0.0" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-hapi/package.json b/plugins/node/opentelemetry-instrumentation-hapi/package.json index e8330cf6ad..cd9835694a 100644 --- a/plugins/node/opentelemetry-instrumentation-hapi/package.json +++ b/plugins/node/opentelemetry-instrumentation-hapi/package.json @@ -28,7 +28,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=8.12.0" + "node": ">=12.0.0" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-ioredis/package.json b/plugins/node/opentelemetry-instrumentation-ioredis/package.json index d4ad128bc4..6d30866585 100644 --- a/plugins/node/opentelemetry-instrumentation-ioredis/package.json +++ b/plugins/node/opentelemetry-instrumentation-ioredis/package.json @@ -33,7 +33,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=8.12.0" + "node": ">=12.0.0" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-knex/package.json b/plugins/node/opentelemetry-instrumentation-knex/package.json index 5d56fabdca..c08dfbfdef 100644 --- a/plugins/node/opentelemetry-instrumentation-knex/package.json +++ b/plugins/node/opentelemetry-instrumentation-knex/package.json @@ -28,7 +28,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=8.12.0" + "node": ">=12.0.0" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-koa/package.json b/plugins/node/opentelemetry-instrumentation-koa/package.json index 598764d0c6..29bc508e41 100644 --- a/plugins/node/opentelemetry-instrumentation-koa/package.json +++ b/plugins/node/opentelemetry-instrumentation-koa/package.json @@ -32,7 +32,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=8.12.0" + "node": ">=12.0.0" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-memcached/package.json b/plugins/node/opentelemetry-instrumentation-memcached/package.json index 709c7a70a7..d085c3d53e 100644 --- a/plugins/node/opentelemetry-instrumentation-memcached/package.json +++ b/plugins/node/opentelemetry-instrumentation-memcached/package.json @@ -30,7 +30,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=8.12.0" + "node": ">=12.0.0" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-mysql/package.json b/plugins/node/opentelemetry-instrumentation-mysql/package.json index fa6bdae066..0cada7dce5 100644 --- a/plugins/node/opentelemetry-instrumentation-mysql/package.json +++ b/plugins/node/opentelemetry-instrumentation-mysql/package.json @@ -28,7 +28,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=8.12.0" + "node": ">=12.0.0" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-mysql2/package.json b/plugins/node/opentelemetry-instrumentation-mysql2/package.json index 6dac20f9ce..6bca852d12 100644 --- a/plugins/node/opentelemetry-instrumentation-mysql2/package.json +++ b/plugins/node/opentelemetry-instrumentation-mysql2/package.json @@ -30,7 +30,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=8.12.0" + "node": ">=12.0.0" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-nestjs-core/package.json b/plugins/node/opentelemetry-instrumentation-nestjs-core/package.json index ce795927ec..510581a47a 100644 --- a/plugins/node/opentelemetry-instrumentation-nestjs-core/package.json +++ b/plugins/node/opentelemetry-instrumentation-nestjs-core/package.json @@ -31,7 +31,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=8.12.0" + "node": ">=12.0.0" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-net/package.json b/plugins/node/opentelemetry-instrumentation-net/package.json index 43a36fe397..c37609d9fb 100644 --- a/plugins/node/opentelemetry-instrumentation-net/package.json +++ b/plugins/node/opentelemetry-instrumentation-net/package.json @@ -29,7 +29,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=8.12.0" + "node": ">=12.0.0" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-pg/package.json b/plugins/node/opentelemetry-instrumentation-pg/package.json index f2ea5acb9b..3e7a62c630 100644 --- a/plugins/node/opentelemetry-instrumentation-pg/package.json +++ b/plugins/node/opentelemetry-instrumentation-pg/package.json @@ -36,7 +36,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=8.12.0" + "node": ">=12.0.0" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-redis/package.json b/plugins/node/opentelemetry-instrumentation-redis/package.json index 0648ce1dc7..bb77ea956f 100644 --- a/plugins/node/opentelemetry-instrumentation-redis/package.json +++ b/plugins/node/opentelemetry-instrumentation-redis/package.json @@ -34,7 +34,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=8.12.0" + "node": ">=12.0.0" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-restify/package.json b/plugins/node/opentelemetry-instrumentation-restify/package.json index fd7b8658f4..9d94eb4443 100644 --- a/plugins/node/opentelemetry-instrumentation-restify/package.json +++ b/plugins/node/opentelemetry-instrumentation-restify/package.json @@ -28,7 +28,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=8.12.0" + "node": ">=12.0.0" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-router/package.json b/plugins/node/opentelemetry-instrumentation-router/package.json index 2adb77d3c0..7badfb1364 100644 --- a/plugins/node/opentelemetry-instrumentation-router/package.json +++ b/plugins/node/opentelemetry-instrumentation-router/package.json @@ -28,7 +28,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=8.12.0" + "node": ">=12.0.0" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-winston/package.json b/plugins/node/opentelemetry-instrumentation-winston/package.json index 48e505a8ef..8be3e61bda 100644 --- a/plugins/node/opentelemetry-instrumentation-winston/package.json +++ b/plugins/node/opentelemetry-instrumentation-winston/package.json @@ -30,7 +30,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=8.12.0" + "node": ">=12.0.0" }, "files": [ "build/src/**/*.js", diff --git a/plugins/web/opentelemetry-instrumentation-document-load/package.json b/plugins/web/opentelemetry-instrumentation-document-load/package.json index 95f2205475..d7d2019b38 100644 --- a/plugins/web/opentelemetry-instrumentation-document-load/package.json +++ b/plugins/web/opentelemetry-instrumentation-document-load/package.json @@ -30,7 +30,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=8.12.0" + "node": ">=12.0.0" }, "files": [ "build/esm/**/*.js", diff --git a/plugins/web/opentelemetry-instrumentation-long-task/package.json b/plugins/web/opentelemetry-instrumentation-long-task/package.json index 49089e9587..3c90fb5c02 100644 --- a/plugins/web/opentelemetry-instrumentation-long-task/package.json +++ b/plugins/web/opentelemetry-instrumentation-long-task/package.json @@ -30,7 +30,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=8.12.0" + "node": ">=12.0.0" }, "files": [ "build/esm/**/*.js", diff --git a/plugins/web/opentelemetry-instrumentation-user-interaction/package.json b/plugins/web/opentelemetry-instrumentation-user-interaction/package.json index 50cb207cfc..883629d2e6 100644 --- a/plugins/web/opentelemetry-instrumentation-user-interaction/package.json +++ b/plugins/web/opentelemetry-instrumentation-user-interaction/package.json @@ -30,7 +30,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=8.12.0" + "node": ">=12.0.0" }, "files": [ "build/esm/**/*.js", diff --git a/plugins/web/opentelemetry-plugin-react-load/package.json b/plugins/web/opentelemetry-plugin-react-load/package.json index 7bb63053a7..814ffabc39 100644 --- a/plugins/web/opentelemetry-plugin-react-load/package.json +++ b/plugins/web/opentelemetry-plugin-react-load/package.json @@ -30,7 +30,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=8.12.0" + "node": ">=12.0.0" }, "files": [ "build/esm/**/*.js", diff --git a/propagators/opentelemetry-propagator-aws-xray/package.json b/propagators/opentelemetry-propagator-aws-xray/package.json index cef8e11b4d..1945bf3592 100644 --- a/propagators/opentelemetry-propagator-aws-xray/package.json +++ b/propagators/opentelemetry-propagator-aws-xray/package.json @@ -28,7 +28,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=8.12.0" + "node": ">=12.0.0" }, "files": [ "build/esm/**/*.js", diff --git a/propagators/opentelemetry-propagator-grpc-census-binary/package.json b/propagators/opentelemetry-propagator-grpc-census-binary/package.json index ea0e321986..d5d9403004 100644 --- a/propagators/opentelemetry-propagator-grpc-census-binary/package.json +++ b/propagators/opentelemetry-propagator-grpc-census-binary/package.json @@ -28,7 +28,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=8.12.0" + "node": ">=12.0.0" }, "files": [ "build/src/**/*.js", diff --git a/propagators/opentelemetry-propagator-ot-trace/package.json b/propagators/opentelemetry-propagator-ot-trace/package.json index 39a869e8e3..a127f5fa21 100644 --- a/propagators/opentelemetry-propagator-ot-trace/package.json +++ b/propagators/opentelemetry-propagator-ot-trace/package.json @@ -30,7 +30,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=8.12.0" + "node": ">=12.0.0" }, "files": [ "build/esm/**/*.js", From 0ff5ca2fc585dc72d2192fd0089f77ec0b594188 Mon Sep 17 00:00:00 2001 From: Rauno Viskus Date: Wed, 22 Jun 2022 14:48:38 +0300 Subject: [PATCH 03/10] chore: add node 18 to CI --- .github/workflows/test-all-versions.yml | 2 +- .github/workflows/unit-test.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test-all-versions.yml b/.github/workflows/test-all-versions.yml index cee519a701..ffb5060bf1 100644 --- a/.github/workflows/test-all-versions.yml +++ b/.github/workflows/test-all-versions.yml @@ -15,7 +15,7 @@ jobs: strategy: fail-fast: false matrix: - node: ["12", "14", "16"] + node: ["12", "14", "16", "18"] runs-on: ubuntu-latest services: memcached: diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml index 0114bb09e8..609c87b010 100644 --- a/.github/workflows/unit-test.yml +++ b/.github/workflows/unit-test.yml @@ -9,7 +9,7 @@ jobs: strategy: fail-fast: false matrix: - node: ["12", "14", "16"] + node: ["12", "14", "16", "18"] include: - node: "12" lerna-extra-args: >- From c0ec6258ee37d875b10605debc5268b910115cd6 Mon Sep 17 00:00:00 2001 From: Rauno Viskus Date: Wed, 22 Jun 2022 14:49:04 +0300 Subject: [PATCH 04/10] fix(resource-detector-alibaba-cloud): call .destroy() directly on the socket --- .../src/detectors/AlibabaCloudEcsDetector.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/detectors/node/opentelemetry-resource-detector-alibaba-cloud/src/detectors/AlibabaCloudEcsDetector.ts b/detectors/node/opentelemetry-resource-detector-alibaba-cloud/src/detectors/AlibabaCloudEcsDetector.ts index 38e54df5ba..859bb15d33 100644 --- a/detectors/node/opentelemetry-resource-detector-alibaba-cloud/src/detectors/AlibabaCloudEcsDetector.ts +++ b/detectors/node/opentelemetry-resource-detector-alibaba-cloud/src/detectors/AlibabaCloudEcsDetector.ts @@ -114,7 +114,7 @@ class AlibabaCloudEcsDetector implements Detector { typeof statusCode !== 'number' || !(statusCode >= 200 && statusCode < 300) ) { - res.destroy(); + res.socket.destroy(); return reject( new Error(`Failed to load page, status code: ${statusCode}`) ); From 84def589fe41a47cf270e9a33042793ee4618887 Mon Sep 17 00:00:00 2001 From: Rauno Viskus Date: Wed, 22 Jun 2022 14:49:44 +0300 Subject: [PATCH 05/10] test: reference the actual error message --- plugins/node/opentelemetry-instrumentation-net/test/tls.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/node/opentelemetry-instrumentation-net/test/tls.test.ts b/plugins/node/opentelemetry-instrumentation-net/test/tls.test.ts index 4ed8dcbab0..032e65ce0b 100644 --- a/plugins/node/opentelemetry-instrumentation-net/test/tls.test.ts +++ b/plugins/node/opentelemetry-instrumentation-net/test/tls.test.ts @@ -128,7 +128,7 @@ describe('NetInstrumentation', () => { ); tlsSocket.on('error', error => { const { tlsSpan } = getTLSSpans(); - assert.strictEqual(tlsSpan.status.message, 'self signed certificate'); + assert.strictEqual(tlsSpan.status.message, error.message); assert.strictEqual(tlsSpan.status.code, SpanStatusCode.ERROR); done(); }); From 1e6bddf481f6e9201a0f77edd4596da987e2c41e Mon Sep 17 00:00:00 2001 From: Rauno Viskus Date: Mon, 27 Jun 2022 18:30:33 +0300 Subject: [PATCH 06/10] test(instrumentation-fastify): check for similarity with ROOT_CONTEXT, not reference equality In the CI there will be 3 instances of the API installed(relative to the repo root): - `./plugins/node/opentelemetry-instrumentation-fastify/node_modules/@opentelemetry/api`, - `./node_modules/@opentelemetry/api`, - `./plugins/node/opentelemetry-instrumentation-fastify/node_modules/@opentelemetry/instrumentation-http/node_modules/@opentelemetry/api`. --- .../test/instrumentation.test.ts | 24 ++++++++++++++----- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/plugins/node/opentelemetry-instrumentation-fastify/test/instrumentation.test.ts b/plugins/node/opentelemetry-instrumentation-fastify/test/instrumentation.test.ts index 399dad3197..8588c24c60 100644 --- a/plugins/node/opentelemetry-instrumentation-fastify/test/instrumentation.test.ts +++ b/plugins/node/opentelemetry-instrumentation-fastify/test/instrumentation.test.ts @@ -15,7 +15,7 @@ */ import * as assert from 'assert'; -import { context, ROOT_CONTEXT, SpanStatusCode } from '@opentelemetry/api'; +import { context, SpanStatusCode } from '@opentelemetry/api'; import { SemanticAttributes } from '@opentelemetry/semantic-conventions'; import { AsyncHooksContextManager } from '@opentelemetry/context-async-hooks'; import { NodeTracerProvider } from '@opentelemetry/sdk-trace-node'; @@ -72,6 +72,14 @@ import { FastifyInstance } from 'fastify/types/instance'; const Fastify = require('fastify'); +const assertRootContextActive = () => { + // Asserting the context.active() to strictly equal ROOT_CONTEXT doesn't + // always work because of the linking and dep resolution. + // Specially in our CI environment there can be multiple instances to + // different @opentelemetry/api and thus ROOT_CONTEXTs in the tree. + assert.strictEqual((context.active() as any)['_currentContext'].size, 0); +}; + function getSpans(): ReadableSpan[] { const spans = memoryExporter.getFinishedSpans().filter(s => { return ( @@ -367,9 +375,14 @@ describe('fastify', () => { }); describe('application hooks', () => { + afterEach(() => { + const spans = getSpans(); + assert.strictEqual(spans.length, 0); + }); + it('onRoute not instrumented', async () => { app.addHook('onRoute', () => { - assert.strictEqual(context.active(), ROOT_CONTEXT); + assertRootContextActive(); }); // add a route to trigger the 'onRoute' hook app.get('/test', (_req: FastifyRequest, reply: FastifyReply) => { @@ -381,7 +394,7 @@ describe('fastify', () => { it('onRegister is not instrumented', async () => { app.addHook('onRegister', () => { - assert.strictEqual(context.active(), ROOT_CONTEXT); + assertRootContextActive(); }); // register a plugin to trigger 'onRegister' hook app.register((fastify, options, done) => { @@ -393,7 +406,7 @@ describe('fastify', () => { it('onReady is not instrumented', async () => { app.addHook('onReady', () => { - assert.strictEqual(context.active(), ROOT_CONTEXT); + assertRootContextActive(); }); await startServer(); @@ -401,11 +414,10 @@ describe('fastify', () => { it('onClose is not instrumented', async () => { app.addHook('onClose', () => { - assert.strictEqual(context.active(), ROOT_CONTEXT); + assertRootContextActive(); }); await startServer(); - await app.close(); }); }); }); From 1dcb34fd4d3f7847347723533cdb3a4ea868c472 Mon Sep 17 00:00:00 2001 From: Rauno Viskus Date: Mon, 27 Jun 2022 20:08:41 +0300 Subject: [PATCH 07/10] chore: remove support for node@12 updating the engines --- .../opentelemetry-browser-extension-autoinjection/package.json | 2 +- .../opentelemetry-resource-detector-alibaba-cloud/package.json | 2 +- detectors/node/opentelemetry-resource-detector-aws/package.json | 2 +- .../node/opentelemetry-resource-detector-docker/package.json | 2 +- detectors/node/opentelemetry-resource-detector-gcp/package.json | 2 +- .../node/opentelemetry-resource-detector-github/package.json | 2 +- metapackages/auto-instrumentations-node/package.json | 2 +- metapackages/auto-instrumentations-web/package.json | 2 +- packages/opentelemetry-host-metrics/package.json | 2 +- packages/opentelemetry-id-generator-aws-xray/package.json | 2 +- packages/opentelemetry-propagation-utils/package.json | 2 +- packages/opentelemetry-test-utils/package.json | 2 +- plugins/node/instrumentation-amqplib/package.json | 2 +- plugins/node/instrumentation-fs/package.json | 2 +- plugins/node/instrumentation-lru-memoizer/package.json | 2 +- plugins/node/instrumentation-tedious/package.json | 2 +- .../node/opentelemetry-instrumentation-aws-lambda/package.json | 2 +- plugins/node/opentelemetry-instrumentation-aws-sdk/package.json | 2 +- plugins/node/opentelemetry-instrumentation-bunyan/package.json | 2 +- .../node/opentelemetry-instrumentation-cassandra/package.json | 2 +- plugins/node/opentelemetry-instrumentation-connect/package.json | 2 +- plugins/node/opentelemetry-instrumentation-dns/package.json | 2 +- .../opentelemetry-instrumentation-express/examples/package.json | 2 +- plugins/node/opentelemetry-instrumentation-express/package.json | 2 +- plugins/node/opentelemetry-instrumentation-fastify/package.json | 2 +- .../opentelemetry-instrumentation-generic-pool/package.json | 2 +- plugins/node/opentelemetry-instrumentation-graphql/package.json | 2 +- plugins/node/opentelemetry-instrumentation-hapi/package.json | 2 +- plugins/node/opentelemetry-instrumentation-ioredis/package.json | 2 +- plugins/node/opentelemetry-instrumentation-knex/package.json | 2 +- plugins/node/opentelemetry-instrumentation-koa/package.json | 2 +- .../node/opentelemetry-instrumentation-memcached/package.json | 2 +- plugins/node/opentelemetry-instrumentation-mongodb/package.json | 2 +- plugins/node/opentelemetry-instrumentation-mysql/package.json | 2 +- plugins/node/opentelemetry-instrumentation-mysql2/package.json | 2 +- .../node/opentelemetry-instrumentation-nestjs-core/package.json | 2 +- plugins/node/opentelemetry-instrumentation-net/package.json | 2 +- plugins/node/opentelemetry-instrumentation-pg/package.json | 2 +- plugins/node/opentelemetry-instrumentation-pino/package.json | 2 +- plugins/node/opentelemetry-instrumentation-redis-4/package.json | 2 +- plugins/node/opentelemetry-instrumentation-redis/package.json | 2 +- plugins/node/opentelemetry-instrumentation-restify/package.json | 2 +- plugins/node/opentelemetry-instrumentation-router/package.json | 2 +- plugins/node/opentelemetry-instrumentation-winston/package.json | 2 +- .../opentelemetry-instrumentation-document-load/package.json | 2 +- .../web/opentelemetry-instrumentation-long-task/package.json | 2 +- .../opentelemetry-instrumentation-user-interaction/package.json | 2 +- plugins/web/opentelemetry-plugin-react-load/package.json | 2 +- propagators/opentelemetry-propagator-aws-xray/package.json | 2 +- .../opentelemetry-propagator-grpc-census-binary/package.json | 2 +- propagators/opentelemetry-propagator-ot-trace/package.json | 2 +- 51 files changed, 51 insertions(+), 51 deletions(-) diff --git a/archive/opentelemetry-browser-extension-autoinjection/package.json b/archive/opentelemetry-browser-extension-autoinjection/package.json index b4c7dafb2a..4edf56de71 100644 --- a/archive/opentelemetry-browser-extension-autoinjection/package.json +++ b/archive/opentelemetry-browser-extension-autoinjection/package.json @@ -23,7 +23,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "peerDependencies": { "@opentelemetry/api": "^1.0.0" diff --git a/detectors/node/opentelemetry-resource-detector-alibaba-cloud/package.json b/detectors/node/opentelemetry-resource-detector-alibaba-cloud/package.json index 341b90548f..2767784f8c 100644 --- a/detectors/node/opentelemetry-resource-detector-alibaba-cloud/package.json +++ b/detectors/node/opentelemetry-resource-detector-alibaba-cloud/package.json @@ -28,7 +28,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "files": [ "build/src/**/*.js", diff --git a/detectors/node/opentelemetry-resource-detector-aws/package.json b/detectors/node/opentelemetry-resource-detector-aws/package.json index 5c8b7252a6..efd0889b52 100644 --- a/detectors/node/opentelemetry-resource-detector-aws/package.json +++ b/detectors/node/opentelemetry-resource-detector-aws/package.json @@ -27,7 +27,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "files": [ "build/src/**/*.js", diff --git a/detectors/node/opentelemetry-resource-detector-docker/package.json b/detectors/node/opentelemetry-resource-detector-docker/package.json index f3f3a102c9..7dd6ea54e1 100644 --- a/detectors/node/opentelemetry-resource-detector-docker/package.json +++ b/detectors/node/opentelemetry-resource-detector-docker/package.json @@ -22,7 +22,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "files": [ "build/src/**/*.js", diff --git a/detectors/node/opentelemetry-resource-detector-gcp/package.json b/detectors/node/opentelemetry-resource-detector-gcp/package.json index ebb5b8485b..59ed47f407 100644 --- a/detectors/node/opentelemetry-resource-detector-gcp/package.json +++ b/detectors/node/opentelemetry-resource-detector-gcp/package.json @@ -27,7 +27,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "files": [ "build/src/**/*.js", diff --git a/detectors/node/opentelemetry-resource-detector-github/package.json b/detectors/node/opentelemetry-resource-detector-github/package.json index c1df6cfb7c..b04c0b1f5f 100644 --- a/detectors/node/opentelemetry-resource-detector-github/package.json +++ b/detectors/node/opentelemetry-resource-detector-github/package.json @@ -28,7 +28,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "files": [ "build/src/**/*.js", diff --git a/metapackages/auto-instrumentations-node/package.json b/metapackages/auto-instrumentations-node/package.json index 7c5e81891d..bf86aecfc3 100644 --- a/metapackages/auto-instrumentations-node/package.json +++ b/metapackages/auto-instrumentations-node/package.json @@ -6,7 +6,7 @@ "homepage": "https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/metapackages/auto-instrumentations-node#readme", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "publishConfig": { "access": "public" diff --git a/metapackages/auto-instrumentations-web/package.json b/metapackages/auto-instrumentations-web/package.json index 571db8831d..4f979cf36a 100644 --- a/metapackages/auto-instrumentations-web/package.json +++ b/metapackages/auto-instrumentations-web/package.json @@ -6,7 +6,7 @@ "homepage": "https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/metapackages/auto-instrumentations-web#readme", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "publishConfig": { "access": "public" diff --git a/packages/opentelemetry-host-metrics/package.json b/packages/opentelemetry-host-metrics/package.json index f65d90a7a4..f89be2fd57 100644 --- a/packages/opentelemetry-host-metrics/package.json +++ b/packages/opentelemetry-host-metrics/package.json @@ -29,7 +29,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "files": [ "build/src/**/*.js", diff --git a/packages/opentelemetry-id-generator-aws-xray/package.json b/packages/opentelemetry-id-generator-aws-xray/package.json index 904455dc1b..169f7a7bec 100644 --- a/packages/opentelemetry-id-generator-aws-xray/package.json +++ b/packages/opentelemetry-id-generator-aws-xray/package.json @@ -37,7 +37,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "files": [ "build/esm/**/*.js", diff --git a/packages/opentelemetry-propagation-utils/package.json b/packages/opentelemetry-propagation-utils/package.json index ec538e40c0..f3b26576b3 100644 --- a/packages/opentelemetry-propagation-utils/package.json +++ b/packages/opentelemetry-propagation-utils/package.json @@ -32,7 +32,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "bugs": { "url": "https://github.com/open-telemetry/opentelemetry-js-contrib/issues" diff --git a/packages/opentelemetry-test-utils/package.json b/packages/opentelemetry-test-utils/package.json index fd0e3e988e..b818511eb5 100644 --- a/packages/opentelemetry-test-utils/package.json +++ b/packages/opentelemetry-test-utils/package.json @@ -31,7 +31,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "bugs": { "url": "https://github.com/open-telemetry/opentelemetry-js-contrib/issues" diff --git a/plugins/node/instrumentation-amqplib/package.json b/plugins/node/instrumentation-amqplib/package.json index e9873da13c..958a25ee1e 100644 --- a/plugins/node/instrumentation-amqplib/package.json +++ b/plugins/node/instrumentation-amqplib/package.json @@ -70,6 +70,6 @@ "typescript": "4.3.5" }, "engines": { - "node": ">=12.0.0" + "node": ">=14" } } diff --git a/plugins/node/instrumentation-fs/package.json b/plugins/node/instrumentation-fs/package.json index 74aee1c633..0dfa1cdb02 100644 --- a/plugins/node/instrumentation-fs/package.json +++ b/plugins/node/instrumentation-fs/package.json @@ -28,7 +28,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/instrumentation-lru-memoizer/package.json b/plugins/node/instrumentation-lru-memoizer/package.json index 94f7dd844f..c2d9eb6643 100644 --- a/plugins/node/instrumentation-lru-memoizer/package.json +++ b/plugins/node/instrumentation-lru-memoizer/package.json @@ -28,7 +28,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/instrumentation-tedious/package.json b/plugins/node/instrumentation-tedious/package.json index c3df836e83..5796b71cb8 100644 --- a/plugins/node/instrumentation-tedious/package.json +++ b/plugins/node/instrumentation-tedious/package.json @@ -33,7 +33,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-aws-lambda/package.json b/plugins/node/opentelemetry-instrumentation-aws-lambda/package.json index a27c22b5cc..76791f9f1d 100644 --- a/plugins/node/opentelemetry-instrumentation-aws-lambda/package.json +++ b/plugins/node/opentelemetry-instrumentation-aws-lambda/package.json @@ -28,7 +28,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-aws-sdk/package.json b/plugins/node/opentelemetry-instrumentation-aws-sdk/package.json index acfa1f9271..768a6fd778 100644 --- a/plugins/node/opentelemetry-instrumentation-aws-sdk/package.json +++ b/plugins/node/opentelemetry-instrumentation-aws-sdk/package.json @@ -78,6 +78,6 @@ "typescript": "4.3.4" }, "engines": { - "node": ">=12.0.0" + "node": ">=14" } } diff --git a/plugins/node/opentelemetry-instrumentation-bunyan/package.json b/plugins/node/opentelemetry-instrumentation-bunyan/package.json index 3564cdaacd..1084870ef0 100644 --- a/plugins/node/opentelemetry-instrumentation-bunyan/package.json +++ b/plugins/node/opentelemetry-instrumentation-bunyan/package.json @@ -30,7 +30,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-cassandra/package.json b/plugins/node/opentelemetry-instrumentation-cassandra/package.json index 100a8fd754..48329ebc9f 100644 --- a/plugins/node/opentelemetry-instrumentation-cassandra/package.json +++ b/plugins/node/opentelemetry-instrumentation-cassandra/package.json @@ -29,7 +29,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-connect/package.json b/plugins/node/opentelemetry-instrumentation-connect/package.json index 39e0efab43..7f47e08600 100644 --- a/plugins/node/opentelemetry-instrumentation-connect/package.json +++ b/plugins/node/opentelemetry-instrumentation-connect/package.json @@ -28,7 +28,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-dns/package.json b/plugins/node/opentelemetry-instrumentation-dns/package.json index f5a7aaf693..07ecd28586 100644 --- a/plugins/node/opentelemetry-instrumentation-dns/package.json +++ b/plugins/node/opentelemetry-instrumentation-dns/package.json @@ -28,7 +28,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-express/examples/package.json b/plugins/node/opentelemetry-instrumentation-express/examples/package.json index ef3a3bf4cc..d9881839a1 100644 --- a/plugins/node/opentelemetry-instrumentation-express/examples/package.json +++ b/plugins/node/opentelemetry-instrumentation-express/examples/package.json @@ -21,7 +21,7 @@ "tracing" ], "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "author": "OpenTelemetry Authors", "license": "Apache-2.0", diff --git a/plugins/node/opentelemetry-instrumentation-express/package.json b/plugins/node/opentelemetry-instrumentation-express/package.json index 8ed017128a..bfbbf8d4c7 100644 --- a/plugins/node/opentelemetry-instrumentation-express/package.json +++ b/plugins/node/opentelemetry-instrumentation-express/package.json @@ -31,7 +31,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-fastify/package.json b/plugins/node/opentelemetry-instrumentation-fastify/package.json index 3a6866c5e1..65d3a7f959 100644 --- a/plugins/node/opentelemetry-instrumentation-fastify/package.json +++ b/plugins/node/opentelemetry-instrumentation-fastify/package.json @@ -28,7 +28,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-generic-pool/package.json b/plugins/node/opentelemetry-instrumentation-generic-pool/package.json index 418ccb9393..487e433fb8 100644 --- a/plugins/node/opentelemetry-instrumentation-generic-pool/package.json +++ b/plugins/node/opentelemetry-instrumentation-generic-pool/package.json @@ -28,7 +28,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-graphql/package.json b/plugins/node/opentelemetry-instrumentation-graphql/package.json index 8d98082743..e9b4d9917a 100644 --- a/plugins/node/opentelemetry-instrumentation-graphql/package.json +++ b/plugins/node/opentelemetry-instrumentation-graphql/package.json @@ -30,7 +30,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-hapi/package.json b/plugins/node/opentelemetry-instrumentation-hapi/package.json index cd9835694a..7ca6cc05fb 100644 --- a/plugins/node/opentelemetry-instrumentation-hapi/package.json +++ b/plugins/node/opentelemetry-instrumentation-hapi/package.json @@ -28,7 +28,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-ioredis/package.json b/plugins/node/opentelemetry-instrumentation-ioredis/package.json index 6d30866585..64daaf8b6c 100644 --- a/plugins/node/opentelemetry-instrumentation-ioredis/package.json +++ b/plugins/node/opentelemetry-instrumentation-ioredis/package.json @@ -33,7 +33,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-knex/package.json b/plugins/node/opentelemetry-instrumentation-knex/package.json index c08dfbfdef..4ad242bd12 100644 --- a/plugins/node/opentelemetry-instrumentation-knex/package.json +++ b/plugins/node/opentelemetry-instrumentation-knex/package.json @@ -28,7 +28,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-koa/package.json b/plugins/node/opentelemetry-instrumentation-koa/package.json index 29bc508e41..dc55af90a4 100644 --- a/plugins/node/opentelemetry-instrumentation-koa/package.json +++ b/plugins/node/opentelemetry-instrumentation-koa/package.json @@ -32,7 +32,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-memcached/package.json b/plugins/node/opentelemetry-instrumentation-memcached/package.json index d085c3d53e..219837e037 100644 --- a/plugins/node/opentelemetry-instrumentation-memcached/package.json +++ b/plugins/node/opentelemetry-instrumentation-memcached/package.json @@ -30,7 +30,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-mongodb/package.json b/plugins/node/opentelemetry-instrumentation-mongodb/package.json index a8279a2d5c..90dd9f40ef 100644 --- a/plugins/node/opentelemetry-instrumentation-mongodb/package.json +++ b/plugins/node/opentelemetry-instrumentation-mongodb/package.json @@ -32,7 +32,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-mysql/package.json b/plugins/node/opentelemetry-instrumentation-mysql/package.json index 0cada7dce5..1c8e54b524 100644 --- a/plugins/node/opentelemetry-instrumentation-mysql/package.json +++ b/plugins/node/opentelemetry-instrumentation-mysql/package.json @@ -28,7 +28,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-mysql2/package.json b/plugins/node/opentelemetry-instrumentation-mysql2/package.json index 6bca852d12..d3046e5fcd 100644 --- a/plugins/node/opentelemetry-instrumentation-mysql2/package.json +++ b/plugins/node/opentelemetry-instrumentation-mysql2/package.json @@ -30,7 +30,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-nestjs-core/package.json b/plugins/node/opentelemetry-instrumentation-nestjs-core/package.json index 510581a47a..e3083c202b 100644 --- a/plugins/node/opentelemetry-instrumentation-nestjs-core/package.json +++ b/plugins/node/opentelemetry-instrumentation-nestjs-core/package.json @@ -31,7 +31,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-net/package.json b/plugins/node/opentelemetry-instrumentation-net/package.json index c37609d9fb..c8e15afd28 100644 --- a/plugins/node/opentelemetry-instrumentation-net/package.json +++ b/plugins/node/opentelemetry-instrumentation-net/package.json @@ -29,7 +29,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-pg/package.json b/plugins/node/opentelemetry-instrumentation-pg/package.json index 3e7a62c630..bc3c6df2bb 100644 --- a/plugins/node/opentelemetry-instrumentation-pg/package.json +++ b/plugins/node/opentelemetry-instrumentation-pg/package.json @@ -36,7 +36,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-pino/package.json b/plugins/node/opentelemetry-instrumentation-pino/package.json index 8e750dfdce..bc38b5da6a 100644 --- a/plugins/node/opentelemetry-instrumentation-pino/package.json +++ b/plugins/node/opentelemetry-instrumentation-pino/package.json @@ -30,7 +30,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-redis-4/package.json b/plugins/node/opentelemetry-instrumentation-redis-4/package.json index 6d6053fd62..94bef42314 100644 --- a/plugins/node/opentelemetry-instrumentation-redis-4/package.json +++ b/plugins/node/opentelemetry-instrumentation-redis-4/package.json @@ -34,7 +34,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-redis/package.json b/plugins/node/opentelemetry-instrumentation-redis/package.json index bb77ea956f..115a29d379 100644 --- a/plugins/node/opentelemetry-instrumentation-redis/package.json +++ b/plugins/node/opentelemetry-instrumentation-redis/package.json @@ -34,7 +34,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-restify/package.json b/plugins/node/opentelemetry-instrumentation-restify/package.json index 9d94eb4443..6f064e8397 100644 --- a/plugins/node/opentelemetry-instrumentation-restify/package.json +++ b/plugins/node/opentelemetry-instrumentation-restify/package.json @@ -28,7 +28,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-router/package.json b/plugins/node/opentelemetry-instrumentation-router/package.json index 7badfb1364..671bc28c94 100644 --- a/plugins/node/opentelemetry-instrumentation-router/package.json +++ b/plugins/node/opentelemetry-instrumentation-router/package.json @@ -28,7 +28,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "files": [ "build/src/**/*.js", diff --git a/plugins/node/opentelemetry-instrumentation-winston/package.json b/plugins/node/opentelemetry-instrumentation-winston/package.json index 8be3e61bda..c14e8c2193 100644 --- a/plugins/node/opentelemetry-instrumentation-winston/package.json +++ b/plugins/node/opentelemetry-instrumentation-winston/package.json @@ -30,7 +30,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "files": [ "build/src/**/*.js", diff --git a/plugins/web/opentelemetry-instrumentation-document-load/package.json b/plugins/web/opentelemetry-instrumentation-document-load/package.json index d7d2019b38..7e513ad490 100644 --- a/plugins/web/opentelemetry-instrumentation-document-load/package.json +++ b/plugins/web/opentelemetry-instrumentation-document-load/package.json @@ -30,7 +30,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "files": [ "build/esm/**/*.js", diff --git a/plugins/web/opentelemetry-instrumentation-long-task/package.json b/plugins/web/opentelemetry-instrumentation-long-task/package.json index 3c90fb5c02..4c85e1a9c4 100644 --- a/plugins/web/opentelemetry-instrumentation-long-task/package.json +++ b/plugins/web/opentelemetry-instrumentation-long-task/package.json @@ -30,7 +30,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "files": [ "build/esm/**/*.js", diff --git a/plugins/web/opentelemetry-instrumentation-user-interaction/package.json b/plugins/web/opentelemetry-instrumentation-user-interaction/package.json index 883629d2e6..dae89a72c3 100644 --- a/plugins/web/opentelemetry-instrumentation-user-interaction/package.json +++ b/plugins/web/opentelemetry-instrumentation-user-interaction/package.json @@ -30,7 +30,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "files": [ "build/esm/**/*.js", diff --git a/plugins/web/opentelemetry-plugin-react-load/package.json b/plugins/web/opentelemetry-plugin-react-load/package.json index 814ffabc39..8716b849ad 100644 --- a/plugins/web/opentelemetry-plugin-react-load/package.json +++ b/plugins/web/opentelemetry-plugin-react-load/package.json @@ -30,7 +30,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "files": [ "build/esm/**/*.js", diff --git a/propagators/opentelemetry-propagator-aws-xray/package.json b/propagators/opentelemetry-propagator-aws-xray/package.json index 1945bf3592..674ea71b8b 100644 --- a/propagators/opentelemetry-propagator-aws-xray/package.json +++ b/propagators/opentelemetry-propagator-aws-xray/package.json @@ -28,7 +28,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "files": [ "build/esm/**/*.js", diff --git a/propagators/opentelemetry-propagator-grpc-census-binary/package.json b/propagators/opentelemetry-propagator-grpc-census-binary/package.json index d5d9403004..9f70884dc6 100644 --- a/propagators/opentelemetry-propagator-grpc-census-binary/package.json +++ b/propagators/opentelemetry-propagator-grpc-census-binary/package.json @@ -28,7 +28,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "files": [ "build/src/**/*.js", diff --git a/propagators/opentelemetry-propagator-ot-trace/package.json b/propagators/opentelemetry-propagator-ot-trace/package.json index a127f5fa21..bb306062fa 100644 --- a/propagators/opentelemetry-propagator-ot-trace/package.json +++ b/propagators/opentelemetry-propagator-ot-trace/package.json @@ -30,7 +30,7 @@ "author": "OpenTelemetry Authors", "license": "Apache-2.0", "engines": { - "node": ">=12.0.0" + "node": ">=14" }, "files": [ "build/esm/**/*.js", From 654932fc1840285e96c76ba5626d95063a21c921 Mon Sep 17 00:00:00 2001 From: Rauno Viskus Date: Mon, 27 Jun 2022 20:10:50 +0300 Subject: [PATCH 08/10] chore: remove test runs on node@12 --- .github/workflows/test-all-versions.yml | 2 +- .github/workflows/unit-test.yml | 8 ++------ 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/.github/workflows/test-all-versions.yml b/.github/workflows/test-all-versions.yml index ffb5060bf1..6052643038 100644 --- a/.github/workflows/test-all-versions.yml +++ b/.github/workflows/test-all-versions.yml @@ -15,7 +15,7 @@ jobs: strategy: fail-fast: false matrix: - node: ["12", "14", "16", "18"] + node: ["14", "16", "18"] runs-on: ubuntu-latest services: memcached: diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml index 609c87b010..bf1ad35409 100644 --- a/.github/workflows/unit-test.yml +++ b/.github/workflows/unit-test.yml @@ -9,11 +9,7 @@ jobs: strategy: fail-fast: false matrix: - node: ["12", "14", "16", "18"] - include: - - node: "12" - lerna-extra-args: >- - --ignore @opentelemetry/instrumentation-redis-4 + node: ["14", "16", "18"] runs-on: ubuntu-latest services: memcached: @@ -159,7 +155,7 @@ jobs: strategy: fail-fast: false matrix: - node: ["12"] + node: ["14"] runs-on: ubuntu-latest env: NPM_CONFIG_UNSAFE_PERM: true From a29dcd3724331bfbb2c2f2ad710d25ac6786c0f5 Mon Sep 17 00:00:00 2001 From: Rauno Viskus Date: Tue, 28 Jun 2022 10:26:57 +0300 Subject: [PATCH 09/10] test(resource-detector-alibaba-cloud): revert change, disable tests for node@18 --- .github/workflows/unit-test.yml | 5 +++++ .../src/detectors/AlibabaCloudEcsDetector.ts | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml index bf1ad35409..e364fa09ff 100644 --- a/.github/workflows/unit-test.yml +++ b/.github/workflows/unit-test.yml @@ -10,6 +10,11 @@ jobs: fail-fast: false matrix: node: ["14", "16", "18"] + include: + # tests fail on node@18, incompatibility with nock? + - node: "18" + lerna-extra-args: >- + --ignore @opentelemetry/resource-detector-alibaba-cloud runs-on: ubuntu-latest services: memcached: diff --git a/detectors/node/opentelemetry-resource-detector-alibaba-cloud/src/detectors/AlibabaCloudEcsDetector.ts b/detectors/node/opentelemetry-resource-detector-alibaba-cloud/src/detectors/AlibabaCloudEcsDetector.ts index 859bb15d33..38e54df5ba 100644 --- a/detectors/node/opentelemetry-resource-detector-alibaba-cloud/src/detectors/AlibabaCloudEcsDetector.ts +++ b/detectors/node/opentelemetry-resource-detector-alibaba-cloud/src/detectors/AlibabaCloudEcsDetector.ts @@ -114,7 +114,7 @@ class AlibabaCloudEcsDetector implements Detector { typeof statusCode !== 'number' || !(statusCode >= 200 && statusCode < 300) ) { - res.socket.destroy(); + res.destroy(); return reject( new Error(`Failed to load page, status code: ${statusCode}`) ); From fceb7b708235bd677de04f064962269c09978a9a Mon Sep 17 00:00:00 2001 From: Rauno Viskus Date: Thu, 15 Sep 2022 12:49:48 +0300 Subject: [PATCH 10/10] fix: turn fastify tests off for node@18 --- .github/workflows/unit-test.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml index e364fa09ff..a3f83977c0 100644 --- a/.github/workflows/unit-test.yml +++ b/.github/workflows/unit-test.yml @@ -15,6 +15,7 @@ jobs: - node: "18" lerna-extra-args: >- --ignore @opentelemetry/resource-detector-alibaba-cloud + --ignore @opentelemetry/instrumentation-fastify runs-on: ubuntu-latest services: memcached: