Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(documentation): mixed up winston readme for hook #910

Merged
merged 2 commits into from
Feb 21, 2022

Conversation

jscherer92
Copy link
Contributor

Which problem is this PR solving?

Fixes #870

Short description of the changes

Updates README to flip in the example for the log hook. The source code has it as a span and then record for args.

Checklist

  • [:heavy_check_mark: ] Ran npm run test-all-versions for the edited package(s) on the latest commit if applicable.

@jscherer92 jscherer92 requested a review from a team February 19, 2022 02:03
@vmarchaud vmarchaud added the bug Something isn't working label Feb 19, 2022
@vmarchaud vmarchaud changed the title fix mixed up winston readme for hook fix(documentation): mixed up winston readme for hook Feb 19, 2022
@vmarchaud vmarchaud added document and removed bug Something isn't working labels Feb 19, 2022
@codecov
Copy link

codecov bot commented Feb 19, 2022

Codecov Report

Merging #910 (990ceaf) into main (f1d2fd0) will decrease coverage by 3.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #910      +/-   ##
==========================================
- Coverage   95.91%   92.63%   -3.28%     
==========================================
  Files          13       15       +2     
  Lines         856      991     +135     
  Branches      178      197      +19     
==========================================
+ Hits          821      918      +97     
- Misses         35       73      +38     
Impacted Files Coverage Δ
...try-instrumentation-winston/src/instrumentation.ts 57.95% <0.00%> (ø)
...tapackages/auto-instrumentations-node/src/utils.ts 97.87% <0.00%> (ø)

@vmarchaud vmarchaud merged commit 0a557e8 into open-telemetry:main Feb 21, 2022
This was referenced Feb 25, 2022
@chingor13 chingor13 mentioned this pull request Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switched parameters of log hook in README
4 participants