Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support mysql2 v1 #908

Merged
merged 5 commits into from
Feb 18, 2022
Merged

Conversation

nozik
Copy link
Contributor

@nozik nozik commented Feb 17, 2022

Which problem is this PR solving?

  • Current instrumentation is configured to support mysql2 version 2.x. It can support version 1.x as well.

Short description of the changes

  • Adapt the configuration to support v1.x as well. Make sure all the tests run successfully.

Checklist

  • Ran npm run test-all-versions for the edited package(s) on the latest commit if applicable.

@nozik nozik requested a review from a team February 17, 2022 06:52
@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #908 (0cdc592) into main (1f68004) will increase coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #908      +/-   ##
==========================================
+ Coverage   95.91%   96.07%   +0.16%     
==========================================
  Files          13       16       +3     
  Lines         856      994     +138     
  Branches      178      202      +24     
==========================================
+ Hits          821      955     +134     
- Misses         35       39       +4     
Impacted Files Coverage Δ
...etry-instrumentation-mysql2/src/instrumentation.ts 95.00% <ø> (ø)
...tapackages/auto-instrumentations-node/src/utils.ts 97.87% <0.00%> (ø)
.../opentelemetry-instrumentation-mysql2/src/utils.ts 100.00% <0.00%> (ø)

@rauno56 rauno56 merged commit d3883d3 into open-telemetry:main Feb 18, 2022
@nozik nozik deleted the support_mysql2_v1 branch February 18, 2022 13:51
This was referenced Feb 25, 2022
@chingor13 chingor13 mentioned this pull request Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants