-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new fastify instrumentation #611
Conversation
Codecov Report
@@ Coverage Diff @@
## main #611 +/- ##
==========================================
- Coverage 96.86% 96.69% -0.17%
==========================================
Files 9 16 +7
Lines 638 1029 +391
Branches 126 159 +33
==========================================
+ Hits 618 995 +377
- Misses 20 34 +14
|
cc @mcollina in case you'd like to take a look (your feedback for pino instrumentation was helpful!), file of most interest: |
plugins/node/opentelemetry-instrumentation-fastify/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
plugins/node/opentelemetry-instrumentation-fastify/src/instrumentation.ts
Show resolved
Hide resolved
Feel free to ping me whenever you need for all instrumentations of Fastify. |
Just a small note - |
Ping @mcollina ;) |
plugins/node/opentelemetry-instrumentation-fastify/package.json
Outdated
Show resolved
Hide resolved
plugins/node/opentelemetry-instrumentation-fastify/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
plugins/node/opentelemetry-instrumentation-fastify/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
plugins/node/opentelemetry-instrumentation-fastify/src/instrumentation.ts
Show resolved
Hide resolved
@blumamir appreciate the detailed review, pls have a look I either fixed or commented. Just still not sure about the export problems you mentioned |
Thanks for addressing the review. Added comments and examples on the open issues. |
…uctor, http.route, context propagation
plugins/node/opentelemetry-instrumentation-fastify/src/instrumentation.ts
Show resolved
Hide resolved
@blumamir addressed the last things, the one you added and the fixes we discussed, please check how it looks now. Thx for all suggestions and samples |
plugins/node/opentelemetry-instrumentation-fastify/src/instrumentation.ts
Show resolved
Hide resolved
plugins/node/opentelemetry-instrumentation-fastify/src/instrumentation.ts
Show resolved
Hide resolved
plugins/node/opentelemetry-instrumentation-fastify/src/instrumentation.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed with @obecny , we think this PR is ready to be merged as is, and later fixes and enhancements can be added later as follow-up PRs.
Since it's currently not in release-please config, it will not be published to npm, allowing me to add a few fixes before it goes public
Which problem is this PR solving?
Short description of the changes