Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otel-js-contrib compat w/ v0.20.0 breaking changes & minor rev release #511

Closed
lizthegrey opened this issue Jun 3, 2021 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@lizthegrey
Copy link
Member

src/server.ts:68:5 - error TS2322: Type 'PgInstrumentation' is not assignable to type 'InstrumentationOption'.
  Type 'PgInstrumentation' is missing the following properties from type 'Instrumentation': setConfig, getConfig

68     new PgInstrumentation(),
       ~~~~~~~~~~~~~~~~~~~~~~~

src/server.ts:70:5 - error TS2322: Type 'ExpressInstrumentation' is not assignable to type 'InstrumentationOption'.
  Type 'ExpressInstrumentation' is missing the following properties from type 'Instrumentation': setConfig, getConfig

70     new ExpressInstrumentation(),
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@Flarna
Copy link
Member

Flarna commented Jun 4, 2021

I guess #513 should fix this

@lizthegrey
Copy link
Member Author

Agree, fixed there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants