ioredis: two spans are generated for operations in offline queue

[blumamir]

What version of OpenTelemetry are you using?

v0.13.0

What version of Node are you using?

12

What did you do?

If possible, provide a recipe for reproducing the error.

// instrument application
const Redis = require("ioredis");
const redis = new Redis();
// call set before connection is established
redis.set('foo', 'bar');

What did you expect to see?

As I am calling set function once, so I expect to see a single span\trace with ioredis set operation.

What did you see instead?

Two different spans in two different traces with ioredis set operation.

Additional context

This happens because of ioredis offline queue.
The call to set creates a call to sendCommand which create the first span, but does not send it as redis status is not ready yet, it is instead being pushed to the offline queue.
When ioredis connect to redis, it calls sendCommand again from the offline queue which generate a second span for the same operation.

This can confuse the user, giving the impression that set (or any other operation) was called more times, and in a different context from what the instrumented code was actually calling.

[github-actions]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

[github-actions]

This issue was closed because it has been stale for 14 days with no activity.

[dyladan]

Not stale afaik

[github-actions]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.