fix(host-metrics): widen MeterProvider type restriction in BaseMetrics class

[brianphillips]

Instead of requiring the MeterProvider class implementation as exported by @opentelemetry/sdk-metrics, change to simply require the MeterProvider interface as exported by @opentelemtry/api. This makes HostMetrics easier to initialize with the meter provider returned by metrics.getMeterProvider()

Which problem is this PR solving?

Initializing the HostMetrics object with a meterProvider as returned by metrics.getMeterProvider() files a type check:

import { metrics } from "@opentelemetry/api";
import { HostMetrics } from "@opentelemetry/host-metrics";

const hostMetrics = new HostMetrics({ meterProvider: metrics.getMeterProvider() }); // <-- fails with TS2739

The compile-time error is:

Type 'MeterProvider' is missing the following properties from type 'MeterProvider': _sharedState, _shutdown, addMetricReader, shutdown, forceFlush [2739]

Short description of the changes

Instead of requiring the MeterProvider class implementation as exported by @opentelemetry/sdk-metrics, I've changed the BaseMetrics abstract class to simply require the MeterProvider interface as exported by @opentelemtry/api. This matches the existing behavior where, if no meterProvider is specified, it uses metrics.getMeterProvider() as the default (but emits a warning).

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.71%. Comparing base (dfb2dff) to head (0407afb).
Report is 239 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2428      +/-   ##
==========================================
- Coverage   90.97%   90.71%   -0.26%     
==========================================
  Files         146      156      +10     
  Lines        7492     7671     +179     
  Branches     1502     1578      +76     
==========================================
+ Hits         6816     6959     +143     
- Misses        676      712      +36     

Files with missing lines	Coverage Δ
...ages/opentelemetry-host-metrics/src/BaseMetrics.ts	100.00% <100.00%> (ø)

... and 76 files with indirect coverage changes

[pichlermarc]

yep that's better - thanks 👍
Note: waiting for @legendecas approval before merging (component owner) 🙂

[pichlermarc]

yep that's better - thanks 👍 Note: waiting for @legendecas approval before merging (component owner) 🙂

(actually @legendecas is out of office for a bit so I'll just merge this - the change seems straight-forward enough) 🙂

[legendecas]

Thanks!

[legendecas]

Does the CLA need to be signed, or is the CLA bot not working?

[brianphillips]

Does the CLA need to be signed, or is the CLA bot not working?

@legendecas - I (my company) has already signed the CLA and the commit that I originally pushed shows that the status was successful. I'm not sure why merging main into this PR isn't showing a ✔️