fix(instrumentation-redis-4): avoid diag.error spam when configured client URL is the empty string #2399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lient URL is the empty string Issue open-telemetry#2389 showed that this instrumentation would *crash* on a Redis client configured with `{url: ''}` (an empty string). The crash was fixed in open-telemetry#2397. This change avoids the once-crashy code, and hence the diag.error spam, by using the same guard before attempting to parse the configured client URL that the Redis client itself does, `if (options?.url)`, Refs: open-telemetry#2389
|
My repro script is described here: #2389 (comment) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2399 +/- ##
==========================================
- Coverage 90.97% 90.54% -0.44%
==========================================
Files 146 157 +11
Lines 7492 7622 +130
Branches 1502 1571 +69
==========================================
+ Hits 6816 6901 +85
- Misses 676 721 +45
|
pichlermarc
approved these changes
Sep 4, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #2389 showed that this instrumentation would crash on a Redis
client configured with
{url: ''}(an empty string). The crash wasfixed in #2397. This change avoids the once-crashy code, and hence
the diag.error spam, by using the same guard before attempting to parse
the configured client URL that the Redis client itself does,
if (options?.url),Refs: #2389