feat: update otel core dependencies #2257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
assigned basti1302, blumamir, david-luna, dyladan, haddasbronfman, hectorhdzg and JamieDanielson
github-actions
bot
added
pkg:instrumentation-pg
pkg:instrumentation-pino
pkg:instrumentation-redis-4
pkg:instrumentation-redis
pkg:instrumentation-router
pkg:instrumentation-winston
pkg:instrumentation-document-load
pkg:instrumentation-long-task
pkg:instrumentation-user-interaction
pkg:instrumentation-dataloader
pkg:instrumentation-socket.io
pkg:instrumentation-cucumber
pkg:sampler-aws-xray
pkg:resource-detector-container
pkg:resource-detector-azure
pkg:test-utils
pkg:instrumentation-runtime-node
pkg:instrumentation-undici
labels
pichlermarc
commented
Jun 5, 2024
| @@ -42,7 +42,7 @@ import type { InstrumentationOption } from '@opentelemetry/instrumentation'; | |||
| */ | |||
| export function createTestNodeSdk(opts: { | |||
| serviceName?: string; | |||
| instrumentations: InstrumentationOption[]; | |||
| instrumentations: (Instrumentation | Instrumentation[])[] | |||
There was a problem hiding this comment.
Reviewer note: this was open-telemetry/opentelemetry-js#4675
| @@ -154,7 +154,7 @@ describe('[email protected]', () => { | |||
| afterEach(done => { | |||
| context.disable(); | |||
| memoryExporter.reset(); | |||
| instrumentation.setConfig(); | |||
| instrumentation.setConfig({}); | |||
There was a problem hiding this comment.
Reviewer note: this was due to open-telemetry/opentelemetry-js#4695
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2257 +/- ##
==========================================
- Coverage 90.97% 90.40% -0.58%
==========================================
Files 146 149 +3
Lines 7492 7514 +22
Branches 1502 1573 +71
==========================================
- Hits 6816 6793 -23
- Misses 676 721 +45 |
trentm
approved these changes
Jun 5, 2024
JacksonWeber
approved these changes
Jun 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates all experimental OpenTelemetry core dependencies, addresses breaking changes.
(Ready for review when tests pass)