Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baggage span processor - key transformation function #2167

Closed
MikeGoldsmith opened this issue Apr 29, 2024 · 1 comment
Closed

Baggage span processor - key transformation function #2167

MikeGoldsmith opened this issue Apr 29, 2024 · 1 comment

Comments

@MikeGoldsmith
Copy link
Member

Consider allowing a user provided transformation function that can alter the baggage entry key before adding to span attribute.

          This implementation currently uses the `BaggageEntry` key to be the attribute name. While it can be useful for some users, I guess prefixing it with something like `baggage.{key}` or suggesting some rename capability, can offer enhanced usability and flexibility to end users in the context of a trace.

I was thinking about the possibility to extend this component with a config object that can be used to supply either a spanAttribtePrefix or a spanAttributeName(baggageKey: string): string function to apply more advanced renames. Adding a config object is something we can always address in a future PR without breaking change I think.

Originally posted by @blumamir in #2114 (comment)

@MikeGoldsmith
Copy link
Member Author

Closing as duplicate of #2166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant