Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[all] support ESM instrumentation for Node.js v18.19, v20, v21 #2021

Closed
6 of 11 tasks
pichlermarc opened this issue Mar 18, 2024 · 0 comments · Fixed by #2180
Closed
6 of 11 tasks

[all] support ESM instrumentation for Node.js v18.19, v20, v21 #2021

pichlermarc opened this issue Mar 18, 2024 · 0 comments · Fixed by #2180

Comments

@pichlermarc
Copy link
Member

pichlermarc commented Mar 18, 2024

Currently we use an older version of import-in-the-middle that does not work with

  • Node.js v18.19
  • Node.js v20
  • Node.js v21

We're blocked on updating to [email protected] in the core repo as that version includes a bug (nodejs/import-in-the-middle#57) which breaks our way of detecting ESM packages. We do this ESM detection in multiple packages.

To resolve this issue there are two options:

Regardless of the option chosen above, we then need to:

  • bump the import-in-the-middle version in core, remove import-in-the-middle form the ignore list in renovate.json
  • wait for a core release (done by a maintainer)
  • update core packages and release a new contrib version (done by a maintainer)
    • no new version needed as this was just a patch release
  • enable testing of previously unsupported Node.js in the workflows of this repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant