Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(instr-aws-sdk): ensure that instrumentation does not crash on bogus SQS.sendMessageBatch input #1999

Merged
merged 4 commits into from
Mar 7, 2024
Merged

fix(instr-aws-sdk): ensure that instrumentation does not crash on bogus SQS.sendMessageBatch input #1999

merged 4 commits into from
Mar 7, 2024

Conversation

trentm
Copy link
Contributor

@trentm trentm commented Mar 6, 2024

Fixes: #1975

@trentm trentm self-assigned this Mar 6, 2024
@trentm trentm requested a review from a team March 6, 2024 19:05
@trentm
Copy link
Contributor Author

trentm commented Mar 6, 2024

prince-symbol
\o/

@codecov Codecov
Copy link

codecov bot commented Mar 6, 2024 •
edited
Loading

Codecov Report

Merging #1999 (433ead2) into main (e24797e) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1999   +/-   ##
=======================================
  Coverage   90.97%   90.97%           
=======================================
  Files         146      146           
  Lines        7492     7494    +2     
  Branches     1502     1503    +1     
=======================================
+ Hits         6816     6818    +2     
  Misses        676      676
Files Coverage Δ
...emetry-instrumentation-aws-sdk/src/services/sqs.ts 100.00% <100.00%> (ø)

pichlermarc
pichlermarc approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks 👍

@pichlermarc pichlermarc merged commit fa7e2f5 into open-telemetry:main Mar 7, 2024
12 checks passed
@dyladan dyladan mentioned this pull request Mar 7, 2024
Merged
@trentm trentm deleted the tm-aws-sdk-forEach-crash branch March 7, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pichlermarc pichlermarc pichlermarc approved these changes

Assignees

@trentm trentm

@blumamir blumamir

Labels
pkg:instrumentation-aws-sdk
Projects
None yet
Milestone
No milestone
3 participants
@trentm @pichlermarc @blumamir