-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(instr-express): normalize paths with double slashes #1995
fix(instr-express): normalize paths with double slashes #1995
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1995 +/- ##
==========================================
+ Coverage 90.97% 96.06% +5.08%
==========================================
Files 146 14 -132
Lines 7492 914 -6578
Branches 1502 199 -1303
==========================================
- Hits 6816 878 -5938
+ Misses 676 36 -640 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good already, thanks for working on this 🙂
Just one question about the added test
plugins/node/opentelemetry-instrumentation-express/test/express.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for working on this 🙂
Which problem is this PR solving?
Short description of the changes
serverWithMiddleware
that contains double slashes, for use in testTest results before the change: