Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(instrumentaiton-runtime-node)!: rename exported instrumentation to match package name #1989

Merged
merged 3 commits into from
Mar 5, 2024
Merged

fix(instrumentaiton-runtime-node)!: rename exported instrumentation to match package name #1989

merged 3 commits into from
Mar 5, 2024

Conversation

pichlermarc
Copy link
Member

@pichlermarc pichlermarc requested a review from a team March 4, 2024 08:40
@pichlermarc pichlermarc mentioned this pull request Mar 4, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Mar 4, 2024 •
edited
Loading

Codecov Report

Merging #1989 (ebd6123) into main (2e9fce4) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1989   +/-   ##
=======================================
  Coverage   91.02%   91.02%           
=======================================
  Files         146      146           
  Lines        7491     7491           
  Branches     1501     1501           
=======================================
  Hits         6819     6819           
  Misses        672      672
Files Coverage Δ
...nstrumentation-runtime-node/src/instrumentation.ts 100.00% <100.00%> (ø)

david-luna
david-luna approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@david-luna david-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should we consider this a breaking change?

@pichlermarc pichlermarc changed the title fix(instrumentaiton-runtime-node): rename exported instrumentation to match package name fix(instrumentaiton-runtime-node)!: rename exported instrumentation to match package name Mar 4, 2024
@pichlermarc
Copy link
Member Author

LGTM. Should we consider this a breaking change?

Yep, it's technically a breaking change, I changed the title. Though that package is not released yet so whatever we do with it is fine 🙂

@trentm
Copy link
Contributor

trentm commented Mar 4, 2024

Thanks!

@pichlermarc pichlermarc merged commit fef1b36 into open-telemetry:main Mar 5, 2024
18 checks passed
@dyladan dyladan mentioned this pull request Mar 5, 2024
Merged
@pichlermarc pichlermarc deleted the fix/instr-naming branch May 2, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamieDanielson JamieDanielson JamieDanielson approved these changes

@david-luna david-luna david-luna approved these changes

@trentm trentm trentm approved these changes

Assignees
No one assigned
Labels
pkg:instrumentation-runtime-node
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pichlermarc @trentm @david-luna @JamieDanielson