Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(instrumentation-graphql): limit support to >=14 <17 #1971

Conversation

pichlermarc
Copy link
Member

Which problem is this PR solving?

  • Preventive: we usually limit instrumentations to support only up to the current major version to avoid breaking users when they update to the next major version.

Short description of the changes

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Merging #1971 (be1797e) into main (d2f59e9) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1971   +/-   ##
=======================================
  Coverage   91.03%   91.03%           
=======================================
  Files         146      146           
  Lines        7492     7492           
  Branches     1501     1501           
=======================================
  Hits         6820     6820           
  Misses        672      672           
Files Coverage Δ
...try-instrumentation-graphql/src/instrumentation.ts 92.81% <100.00%> (ø)

@pichlermarc pichlermarc merged commit ff40cc8 into open-telemetry:main Mar 6, 2024
15 checks passed
@dyladan dyladan mentioned this pull request Mar 6, 2024
@pichlermarc pichlermarc deleted the fix/graphql-support-range branch May 2, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants