-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update otel core experimental #1866
fix(deps): update otel core experimental #1866
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1866 +/- ##
=======================================
Coverage 91.45% 91.45%
=======================================
Files 144 144
Lines 7406 7406
Branches 1483 1483
=======================================
Hits 6773 6773
Misses 633 633 |
Converting back to draft as it does seem to add some other issues. Edit: looks like it's actually iitm swallowing the CJS exports |
Ah, now I get it. I think this depends on the fix included in |
Ah, it looks like this is actually failing as IITM is swallowing the (cjs) exports from instrumentation-http |
Tests are all green now, marking as ready-for-review. Some changes I made:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pichlermarc Thanks very much for working through this!
* fix(deps): update opentelemetry-js monorepo * fix(deps): update otel core experimental to ^0.46.0 * fix: re-generate package-lock.json * fix: test with updated import-in-the-middle hook * fix: use type-compatible versions of rxjs * fix(mongodb-example): remove unneeded useUnifiedTopology parameter * fix: remove iitm 1.7.2 again, use otel hook (iitm 1.7.1) --------- Co-authored-by: Mend Renovate <[email protected]>
This is the renovate PR #1865 merged with #1864 and a newly generated
package-lock.json
- for some reason renovate did leave the package-lock.json in a weird state where some old packages were still used leading to compilation failures due to differing types.This PR also updates the
@opentelemetry/contrib-test-utils
for@opentelemetry/sampler-aws-xray
.Note: we've actually had this problem before that it's left behind for some reason. (#1582) I previously assumed it was because an x-ray sampler PR was merged with old dependencies after the utils were already updated on main, but now I'm not exactly sure why this is happening - the only thing that's different to my eye is that it's a private package.