Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update otel core experimental #1866

Conversation

pichlermarc
Copy link
Member

This is the renovate PR #1865 merged with #1864 and a newly generated package-lock.json - for some reason renovate did leave the package-lock.json in a weird state where some old packages were still used leading to compilation failures due to differing types.

This PR also updates the @opentelemetry/contrib-test-utils for @opentelemetry/sampler-aws-xray.

Note: we've actually had this problem before that it's left behind for some reason. (#1582) I previously assumed it was because an x-ray sampler PR was merged with old dependencies after the utils were already updated on main, but now I'm not exactly sure why this is happening - the only thing that's different to my eye is that it's a private package.

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Merging #1866 (677188f) into main (6b7eb19) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1866   +/-   ##
=======================================
  Coverage   91.45%   91.45%           
=======================================
  Files         144      144           
  Lines        7406     7406           
  Branches     1483     1483           
=======================================
  Hits         6773     6773           
  Misses        633      633           

@pichlermarc
Copy link
Member Author

pichlermarc commented Dec 15, 2023

Converting back to draft as it does seem to add some other issues. Looks like it's pulling in some very old version of instrumentation-http. I wonder if that has something to do with the outdated examples in this repo.

Edit: looks like it's actually iitm swallowing the CJS exports

@pichlermarc
Copy link
Member Author

pichlermarc commented Dec 19, 2023

Ah, now I get it. I think this depends on the fix included in [email protected]. I'll try it out locally. We should probably consider changing the version in @opentelemetry/instrumentation to allow for 1.7.x instead of pinning it.

@pichlermarc
Copy link
Member Author

Ah, it looks like this is actually failing as IITM is swallowing the (cjs) exports from instrumentation-http

@pichlermarc
Copy link
Member Author

pichlermarc commented Dec 21, 2023

Tests are all green now, marking as ready-for-review. Some changes I made:

  • delete package-lock.json and generate a new one
  • removed useUnifiedTopology from the mongodb-example as this is the default in previous versions and would not compile anymore with the updated one that was installed with a fresh npm install (bf19f7b)
  • bump the rxjs dev dependency of instrumentation-nestjs-core as it was conflicting with types from another dev dependency used in other parts of the repo (7845a6b)

@pichlermarc pichlermarc marked this pull request as ready for review December 21, 2023 11:07
Copy link
Contributor

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pichlermarc Thanks very much for working through this!

@pichlermarc pichlermarc merged commit 9366543 into open-telemetry:main Dec 22, 2023
14 checks passed
@pichlermarc pichlermarc deleted the renovate/otel-core-experimental branch December 22, 2023 08:45
@dyladan dyladan mentioned this pull request Dec 22, 2023
david-luna pushed a commit to david-luna/opentelemetry-js-contrib that referenced this pull request Dec 27, 2023
* fix(deps): update opentelemetry-js monorepo

* fix(deps): update otel core experimental to ^0.46.0

* fix: re-generate package-lock.json

* fix: test with updated import-in-the-middle hook

* fix: use type-compatible versions of rxjs

* fix(mongodb-example): remove unneeded useUnifiedTopology parameter

* fix: remove iitm 1.7.2 again, use otel hook (iitm 1.7.1)

---------

Co-authored-by: Mend Renovate <[email protected]>
@dyladan dyladan mentioned this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.