Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opentelemetry-instrumentation-graphql doesn't follow GraphQL semantic conventions #1612

Closed
1 of 2 tasks
SonjaChevre opened this issue Jul 26, 2023 · 2 comments
Closed
1 of 2 tasks

Comments

@SonjaChevre
Copy link

  • This only affects the JavaScript OpenTelemetry library
  • This may affect other libraries, but I would like to get opinions here first

Hi! in the process of writing a blog post about GraphQL & OpenTelemetry, I have noticed that the GraphQL instrumentation doesn't respect the current (basic) GraphQL semantic convention.

A couple of findings:

  • One example: using graphql.source for the query and not graphql.document
  • On the other side, opentelemetry-instrumentation-graphql provides lots of insights that could be standardised to the semantic conventions
  • Last, adding information about GraphQL errors on the spans (missing from the instrumentation and the semantic conventions) could have a lot of value for users - see here: https://tyk.io/blog/observing-graphql-errors-with-opentelemetry/

Making a note here, to let you know I have created an issue to suggest working on better semantic conventions for GraphQL: open-telemetry/semantic-conventions#182 - would welcome anybody that join this initiative.

Thanks,
Sonja

@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Sep 25, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

This issue was closed because it has been stale for 14 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant