amqplib looses Baggage

[nerumo]

What version of OpenTelemetry are you using?

amqplib: 0.32.0

What version of Node are you using?

19.4.0

What did you do?

I'm using baggage propagators and I realized that I loose the baggage when I consume messages.

What did you expect to see?

propagator.getBaggage(context.active()) should return the baggage of the amqp header

What did you see instead?

I get null/empty

Additional context

I already found the problem: the wrong context is passed into the setSpan method.

Right now, the context.active() is passed in, but actually the parentContext must be passed in since only this one contains the baggage.

[Flarna]

This seems to be not limited to amqplib, e.g. grpc-js looks similar.

[nerumo]

agreed, but there the active context actually should have changed since they are doing a context.with(...) (Code), but IMHO it should be solved with a single context.with

[Flarna]

right, I haven't seen this additional context.with(). I looked into http and grpc and http shows more or less what you propose (code).

[blumamir]

Thanks @nerumo
Would you like to contribute a PR with a fix?