fix(instrumentation-net): make tls span parent of net span #1342
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
@opentelemetry/instrumentation-net
, when tls is used, 2 spans are produced: one for tls and one for network. They are currently siblings to each other and the trace structure does not indicate anything about their relationship, even though they relate to the same tls transaction. In the lack of ambient context (HTTP request span / db driver span) they belong to 2 different traces, as thenet
span starts in an empty ambient context, thus becomes a root span.Short description of the changes