-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plugin for restify #134
Comments
Hi, I want to start contributing to OpenTelemetry, can I grab this issue? |
@adamegyed You mentioned this yesterday. Could you update your plans here and/or sync with @menishmueli ? |
Hi @menishmueli ! I've started work on this plugin a while back, but ran into some blockers and held off on claiming the ticket. Recently though I think I found a solution, and I plan on starting a draft PR today. Feel free to contribute to it if you'd like. |
Hi, @adamegyed! How far did you get with the implementation? |
Hi @rauno56! I ended up pivoting to a different project at the time, but if you want an idea of how instrumenting a new plugin is done, you could take a look at how the Hapi integration was implemented here: #171. I do believe that some of the organization around plugins and instrumentation might have changed since, so it might also help to look at more recent PRs and the spec. |
Thanks, @adamegyed! |
Can be closed now, @vmarchaud. |
This is supported by the current offerings of at least Google (https://github.com/googleapis/cloud-trace-nodejs#what-gets-traced) and Lightstep (https://docs.lightstep.com/docs/nodejs-auto-instrumentation#frameworks), so it would be good to have it added in OpenTelemetry.
The text was updated successfully, but these errors were encountered: