Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin for restify #134

Closed
kintel opened this issue Jul 9, 2020 · 7 comments
Closed

Add plugin for restify #134

kintel opened this issue Jul 9, 2020 · 7 comments

Comments

@kintel
Copy link

kintel commented Jul 9, 2020

This is supported by the current offerings of at least Google (https://github.com/googleapis/cloud-trace-nodejs#what-gets-traced) and Lightstep (https://docs.lightstep.com/docs/nodejs-auto-instrumentation#frameworks), so it would be good to have it added in OpenTelemetry.

@dyladan dyladan added instrumentation-request up-for-grabs Good for taking. Extra help will be provided by maintainers labels Jul 9, 2020
@menishmueli
Copy link

Hi, I want to start contributing to OpenTelemetry, can I grab this issue?

@kintel
Copy link
Author

kintel commented Aug 11, 2020

@adamegyed You mentioned this yesterday. Could you update your plans here and/or sync with @menishmueli ?

@adamegyed
Copy link

Hi @menishmueli ! I've started work on this plugin a while back, but ran into some blockers and held off on claiming the ticket. Recently though I think I found a solution, and I plan on starting a draft PR today. Feel free to contribute to it if you'd like.

@rauno56
Copy link
Member

rauno56 commented Mar 22, 2021

Hi, @adamegyed! How far did you get with the implementation?
I'd love to start working on it and either take your work to the finish line or start my own.

@adamegyed
Copy link

Hi @rauno56! I ended up pivoting to a different project at the time, but if you want an idea of how instrumenting a new plugin is done, you could take a look at how the Hapi integration was implemented here: #171. I do believe that some of the organization around plugins and instrumentation might have changed since, so it might also help to look at more recent PRs and the spec.

@rauno56
Copy link
Member

rauno56 commented Apr 16, 2021

Thanks, @adamegyed!
Restify instrumentation landed in b7d84d1 #416, but not yet published.

@vmarchaud vmarchaud removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Apr 16, 2021
@rauno56
Copy link
Member

rauno56 commented May 5, 2021

Can be closed now, @vmarchaud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants