Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(redis & redis-4): only serialize command name in db.statement attribute #1294

Closed
haddasbronfman opened this issue Nov 20, 2022 · 2 comments
Closed

feat(redis & redis-4): only serialize command name in db.statement attribute #1294

haddasbronfman opened this issue Nov 20, 2022 · 2 comments
Assignees
@haddasbronfman
Labels
bug Something isn't working

Comments

@haddasbronfman
Copy link
Member

haddasbronfman commented Nov 20, 2022 •
edited
Loading

What did you do?

I used the redis instrumentation

What did you expect to see?

I expected to see the arguments of my command. e.g. hset map1 key1 value1

What did you see instead?

I saw only the name of the command. e.g. hset

Additional context

This issue was already solved for ioredis here, I want to solve it also for redis and redis-4.
@haddasbronfman haddasbronfman added the bug Something isn't working label Nov 20, 2022
@haddasbronfman
Copy link
Member Author

Can you please assign this to me? thanks.

@blumamir blumamir changed the title feat(redis & redis-4): only serialize non sensitive arguments in db statement attribute feat(redis & redis-4): only serialize command name db statement attribute Nov 20, 2022
@blumamir blumamir changed the title feat(redis & redis-4): only serialize command name db statement attribute feat(redis & redis-4): only serialize command name db in statement attribute Nov 20, 2022
@blumamir blumamir changed the title feat(redis & redis-4): only serialize command name db in statement attribute feat(redis & redis-4): only serialize command name in db.statement attribute Nov 20, 2022
This was referenced Nov 21, 2022
Closed
Merged
@blumamir
Copy link
Member

fixed in #1299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haddasbronfman haddasbronfman

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@blumamir @haddasbronfman