Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mongodb): use net.peer namespace for mongo host and port #1257

Merged
merged 4 commits into from
Oct 30, 2022

Conversation

blumamir
Copy link
Member

Which problem is this PR solving?

Short description of the changes

  • Changed the attributes "net.host.name" and "net.host.port" to the correct ones according to spec "net.peer.name" and "net.peer.port".

From the spec:

Sometimes host name is only available to instrumentation as a string which may contain DNS name or IP address. net.peer.name SHOULD be set to the available known hostname (e.g., "127.0.0.1" if connecting to an URL https://127.0.0.1.com/foo).

Thank you @lmolkova for the help

@blumamir blumamir requested a review from a team October 27, 2022 19:50
@github-actions github-actions bot requested a review from osherv October 27, 2022 19:50
@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Merging #1257 (5787c3e) into main (180b336) will decrease coverage by 21.08%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1257       +/-   ##
===========================================
- Coverage   96.08%   75.00%   -21.09%     
===========================================
  Files          14        3       -11     
  Lines         893      296      -597     
  Branches      191       75      -116     
===========================================
- Hits          858      222      -636     
- Misses         35       74       +39     
Impacted Files Coverage Δ
...try-instrumentation-mongodb/src/instrumentation.ts 68.93% <ø> (ø)
...umentation-user-interaction/src/instrumentation.ts
...lugin-react-load/src/BaseOpenTelemetryComponent.ts
...ation-user-interaction/src/enums/AttributeNames.ts
...entation-document-load/src/enums/AttributeNames.ts
...y-instrumentation-long-task/src/instrumentation.ts
...strumentation-document-load/src/instrumentation.ts
...metry-propagator-aws-xray/src/AWSXRayPropagator.ts
...etapackages/auto-instrumentations-web/src/utils.ts
...erator-aws-xray/src/internal/xray-id-generation.ts
... and 8 more

@blumamir
Copy link
Member Author

@osherv is the component owner, but I need another approve to merge:

Merging is blocked
Merging can be performed automatically with 1 approving review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants