-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: container ID detector for cgroup v2 #1181
Conversation
feat: Docker v2 detector
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1181 +/- ##
==========================================
- Coverage 96.08% 96.05% -0.03%
==========================================
Files 14 16 +2
Lines 893 937 +44
Branches 191 198 +7
==========================================
+ Hits 858 900 +42
- Misses 35 37 +2
|
detectors/node/opentelemetry-resource-detector-docker/src/detectors/DockerDetector.ts
Outdated
Show resolved
Hide resolved
detectors/node/opentelemetry-resource-detector-docker/src/detectors/DockerDetector.ts
Outdated
Show resolved
Hide resolved
detectors/node/opentelemetry-resource-detector-docker/src/detectors/DockerDetector.ts
Outdated
Show resolved
Hide resolved
detectors/node/opentelemetry-resource-detector-docker/src/detectors/DockerDetector.ts
Outdated
Show resolved
Hide resolved
detectors/node/opentelemetry-resource-detector-docker/src/detectors/DockerDetector.ts
Outdated
Show resolved
Hide resolved
detectors/node/opentelemetry-resource-detector-docker/src/detectors/DockerDetector.ts
Outdated
Show resolved
Hide resolved
detectors/node/opentelemetry-resource-detector-docker/src/detectors/DockerDetector.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
All open threads are optional. Feel free to resolve or implement
detectors/node/opentelemetry-resource-detector-container/src/detectors/ContainerDetector.ts
Outdated
Show resolved
Hide resolved
detectors/node/opentelemetry-resource-detector-container/src/detectors/ContainerDetector.ts
Outdated
Show resolved
Hide resolved
detectors/node/opentelemetry-resource-detector-container/test/ContainerDetector.test.ts
Outdated
Show resolved
Hide resolved
detectors/node/opentelemetry-resource-detector-container/test/ContainerDetector.test.ts
Show resolved
Hide resolved
@blumamir I addressed the rest of the comments as well - please merge when you get a chance. Thank you so much for the review. |
detectors/node/opentelemetry-resource-detector-container/test/ContainerDetector.test.ts
Outdated
Show resolved
Hide resolved
detectors/node/opentelemetry-resource-detector-container/src/detectors/ContainerDetector.ts
Outdated
Show resolved
Hide resolved
Thanks for working on this. Please add tests with files having multiple lines and we'll be golden! |
@rauno56 Changed existing test to take multiple lines as input - I think we should be covered - thank you for the review - feel free to merge when you can. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bearing with the long back-and-forth! I don't have any blockers.
Only curious about the length check.
@rauno56 I strongly believe in code reviews like these ones, may be a bit long but it's a good learning and quality check. Thank you for an engaged review. |
Which problem is this PR solving?
#1173
docker v2 detector
Short description of the changes
Checklist
npm run test-all-versions
for the edited package(s) on the latest commit if applicable.