Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ioredis): requireParentSpan not applied to connect spans #1151

Merged
merged 5 commits into from
Sep 7, 2022

Conversation

evantorrie
Copy link
Contributor

@evantorrie evantorrie commented Sep 3, 2022

Which problem is this PR solving?

Fixes #1150

Short description of the changes

Added similar hasParent check at beginning of connect instrumentation.

Checklist

  • Ran npm run test-all-versions for the edited package(s) on the latest commit if applicable.

@evantorrie evantorrie changed the title Add tests to validate that requireParentSpan applies to connect fix: Add tests to validate that requireParentSpan applies to connect Sep 3, 2022
@codecov
Copy link

codecov bot commented Sep 3, 2022

Codecov Report

Merging #1151 (7a779a8) into main (d8767a9) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1151      +/-   ##
==========================================
- Coverage   96.07%   95.88%   -0.19%     
==========================================
  Files          14       17       +3     
  Lines         892     1046     +154     
  Branches      191      214      +23     
==========================================
+ Hits          857     1003     +146     
- Misses         35       43       +8     
Impacted Files Coverage Δ
...try-instrumentation-ioredis/src/instrumentation.ts 91.76% <100.00%> (ø)
...tapackages/auto-instrumentations-node/src/utils.ts 98.00% <0.00%> (ø)
...opentelemetry-instrumentation-ioredis/src/utils.ts 100.00% <0.00%> (ø)

@evantorrie evantorrie changed the title fix: Add tests to validate that requireParentSpan applies to connect fix(ioredis): Add tests to validate that requireParentSpan applies to connect Sep 3, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@evantorrie evantorrie marked this pull request as ready for review September 3, 2022 17:19
@evantorrie evantorrie requested a review from a team September 3, 2022 17:19
@blumamir blumamir changed the title fix(ioredis): Add tests to validate that requireParentSpan applies to connect fix(ioredis): requireParentSpan not applied to connect spans Sep 7, 2022
@blumamir blumamir merged commit d3cb60d into open-telemetry:main Sep 7, 2022
@dyladan dyladan mentioned this pull request Sep 7, 2022
@evantorrie evantorrie deleted the ioredis-parentspan branch September 7, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ioredis instrumentation should obey requireParentSpan for connect
3 participants