Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(readme): Correct urls to npm #1144

Merged
merged 2 commits into from
Sep 7, 2022
Merged

Conversation

carlpett
Copy link
Contributor

Apparent copy/paste error pointed to instrumentation-dns instead of instrumentation-express

Which problem is this PR solving?

  • Wrong links

Short description of the changes

  • Adjusted links to point to correct package

Checklist

  • Ran npm run test-all-versions for the edited package(s) on the latest commit if applicable.

Apparent copy/paste error pointed to instrumentation-dns instead of
instrumentation-express
@carlpett carlpett requested a review from a team August 31, 2022 19:23
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #1144 (a5fdcce) into main (bf29530) will increase coverage by 0.56%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1144      +/-   ##
==========================================
+ Coverage   96.07%   96.63%   +0.56%     
==========================================
  Files          14       20       +6     
  Lines         892     1130     +238     
  Branches      191      245      +54     
==========================================
+ Hits          857     1092     +235     
- Misses         35       38       +3     
Impacted Files Coverage Δ
...trumentation-express/src/enums/ExpressLayerType.ts 100.00% <0.00%> (ø)
...nstrumentation-express/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
...opentelemetry-instrumentation-express/src/types.ts 100.00% <0.00%> (ø)
...tapackages/auto-instrumentations-node/src/utils.ts 98.00% <0.00%> (ø)
...try-instrumentation-express/src/instrumentation.ts 99.29% <0.00%> (ø)
...opentelemetry-instrumentation-express/src/utils.ts 97.36% <0.00%> (ø)

@blumamir blumamir merged commit d8767a9 into open-telemetry:main Sep 7, 2022
@dyladan dyladan mentioned this pull request Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants