fix(instrumentation-user-interaction): addEventListener throws when calling with useCapture = null #1045
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
When
addEventListener
is called withuseCapture = null
(technically against the spec but that stops nobody), event listener instrumentation throws and breaks appsRepo: https://codesandbox.io/s/otel-user-interaction-event-capture-null-tpmfzt?file=/src/listener-null.js
Example of this error spotted in the wild: react-onclickoutside
Caused by
typeof null === 'object'
Short description of the changes