From 28e209a9da36bc4e1f8c2b0db7360170ed46cb80 Mon Sep 17 00:00:00 2001
From: Trent Mick <trentm@gmail.com>
Date: Thu, 7 Nov 2024 08:55:29 -0800
Subject: [PATCH] fix(instrumentation-undici): fix a possible crash if the
 request path is a full URL (#2518)

Closes: #2471
---
 .../node/instrumentation-undici/src/undici.ts |  9 +++++-
 .../test/undici.test.ts                       | 28 +++++++++++++++++++
 2 files changed, 36 insertions(+), 1 deletion(-)

diff --git a/plugins/node/instrumentation-undici/src/undici.ts b/plugins/node/instrumentation-undici/src/undici.ts
index 5a6799137f..949b1e11c7 100644
--- a/plugins/node/instrumentation-undici/src/undici.ts
+++ b/plugins/node/instrumentation-undici/src/undici.ts
@@ -188,7 +188,14 @@ export class UndiciInstrumentation extends InstrumentationBase<UndiciInstrumenta
     }
 
     const startTime = hrTime();
-    const requestUrl = new URL(request.origin + request.path);
+    let requestUrl;
+    try {
+      requestUrl = new URL(request.path, request.origin);
+    } catch (err) {
+      this._diag.warn('could not determine url.full:', err);
+      // Skip instrumenting this request.
+      return;
+    }
     const urlScheme = requestUrl.protocol.replace(':', '');
     const requestMethod = this.getRequestMethod(request.method);
     const attributes: Attributes = {
diff --git a/plugins/node/instrumentation-undici/test/undici.test.ts b/plugins/node/instrumentation-undici/test/undici.test.ts
index 451bb71f3f..effa2b3a3f 100644
--- a/plugins/node/instrumentation-undici/test/undici.test.ts
+++ b/plugins/node/instrumentation-undici/test/undici.test.ts
@@ -831,5 +831,33 @@ describe('UndiciInstrumentation `undici` tests', function () {
         'user-agent is undefined'
       );
     });
+
+    it('should create valid span if request.path is a full URL', async function () {
+      let spans = memoryExporter.getFinishedSpans();
+      assert.strictEqual(spans.length, 0);
+
+      const origin = `${protocol}://${hostname}:${mockServer.port}`;
+      const fullUrl = `${origin}/?query=test`;
+      const client = new undici.Client(origin);
+      const res = await client.request({
+        path: fullUrl,
+        method: 'GET',
+      });
+      await consumeResponseBody(res.body);
+
+      spans = memoryExporter.getFinishedSpans();
+      const span = spans[0];
+      assert.ok(span, 'a span is present');
+      assert.strictEqual(spans.length, 1);
+      assertSpan(span, {
+        hostname: 'localhost',
+        httpStatusCode: res.statusCode,
+        httpMethod: 'GET',
+        path: '/',
+        query: '?query=test',
+        resHeaders: res.headers,
+      });
+      assert.strictEqual(span.attributes['url.full'], fullUrl);
+    });
   });
 });