Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require empty objects when referencing custom components #6891

Merged

Conversation

jack-berg
Copy link
Member

Currently, when referencing a custom processor, exporter, sampler, etc, you need to specify an empty object as config (i.e. {}).

This is a bug.

This PR fixes the bug.

@jack-berg jack-berg requested a review from a team as a code owner November 18, 2024 19:27
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.28%. Comparing base (46b2fcd) to head (661c417).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6891      +/-   ##
============================================
- Coverage     90.29%   90.28%   -0.01%     
- Complexity     6588     6589       +1     
============================================
  Files           729      729              
  Lines         19767    19769       +2     
  Branches       1944     1945       +1     
============================================
+ Hits          17848    17849       +1     
  Misses         1327     1327              
- Partials        592      593       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Killer. Love for the users.

@jack-berg jack-berg merged commit cde3d45 into open-telemetry:main Nov 18, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants