Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote Span addLink to stable API #6317

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

jack-berg
Copy link
Member

AddLink was stabilized in the spec here: open-telemetry/opentelemetry-specification#3887

@jack-berg jack-berg requested a review from a team March 21, 2024 20:06
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.02%. Comparing base (7926c45) to head (441a4ce).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6317      +/-   ##
============================================
- Coverage     91.04%   91.02%   -0.02%     
+ Complexity     5726     5725       -1     
============================================
  Files           625      624       -1     
  Lines         16744    16744              
  Branches       1713     1713              
============================================
- Hits          15244    15242       -2     
  Misses         1006     1006              
- Partials        494      496       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

public API change approved (didn't review the implementation much)

@jack-berg jack-berg merged commit d7370f3 into open-telemetry:main Apr 4, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants