Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Jaeger "helper function" to create the export pipeline. #797

Closed
jkwatson opened this issue Jan 24, 2020 · 5 comments · Fixed by #977
Closed

Create Jaeger "helper function" to create the export pipeline. #797

jkwatson opened this issue Jan 24, 2020 · 5 comments · Fixed by #977
Assignees
Milestone

Comments

@jkwatson
Copy link
Contributor

No description provided.

@bogdandrutu bogdandrutu added this to the Beta release candidate milestone Feb 14, 2020
@pavolloffay pavolloffay self-assigned this Feb 24, 2020
@pavolloffay
Copy link
Member

@jkwatson @carlosalberto please provide more details in the description.

@carlosalberto
Copy link
Contributor

From the last meeting, it was mentioned that details should be found in: open-telemetry/opentelemetry-specification#231

@carlosalberto
Copy link
Contributor

It sounds this is the specific part @pavolloffay

One missing functionality is the ability to configure the client via environmental variables https://www.jaegertracing.io/docs/1.13/client-features/. This was proven to be useful for cloud/containerized deployments.

@bogdandrutu
Copy link
Member

bogdandrutu commented Feb 25, 2020

I think we should have a method like:

void installDefaultJaegerExporter(TraceProviderSdk traceProviderSdk) {
  // Creates the exporter
  // Configures default values for batch SpanProcessor and installs the exporter to it.
  // If you want by default to use Disruptor async SpanProcessor, configure and install that as well
  // Installs the default configured SpanProcessor to the traceProviderSdk.
}

This is to simplify user life when it comes to configure Jaeger, they should not have to configure all batching etc just to get things running (they can do the advanced config if needed).

@bogdandrutu
Copy link
Member

@pavolloffay for example even in our examples https://github.com/open-telemetry/opentelemetry-java/blob/master/examples/jaeger/src/main/java/io/opentelemetry/example/JaegerExample.java#L28 we do create a poor export pipeline that exports spans one by one, that method should be replaced by this method that needs to be implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants