-
Notifications
You must be signed in to change notification settings - Fork 858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement spec: MetricFilter #6107
Comments
@jack-berg I'm starting to implement this |
Hi are there any updates for this issue? I have an use case for it. I can also take over implementation if needed. |
Are you sure you need it? Its a pretty complicated feature that seems to make sense when 1. you have a huge number of distinct series such that reading the aggregated state of all is too expensive. 2. you're implementing you're own pull-based metric reader, which somehow includes the filter as an input (i.e. query parameter). The memory churn associated with reading aggregated state of many series is significantly lower these days thanks to the |
Our usecase is unconventional in that third-parties will be exporting metrics to us, and we will be providing them with a way to filter out metrics they don't want to be sending. The alternative would be writing our own reader, but this way seems cleaner. |
To make use of MetricFilter, you'd need to write your own reader:
So you want to provide a way for these third-parties to configure which metrics are exported? You can do this today with views. Problem with views is that they are global, so if the third-party wants the metric and just doesn't want to send it to you, views won't be useful. An alternative is to have the third parties wrap their exporters with InterceptableMetricExporter, and have them configure a predicate dictating which metrics are exported. |
Didn't know about the interceptors! That should work for our use case. Thanks for recommending |
Describe the solution you'd like
Implement the following 3 features, as shown in compliance metric:
Additional context
The metric filter specifications PR: open-telemetry/opentelemetry-specification#3566
Plan
The text was updated successfully, but these errors were encountered: