Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate whether we can / should relocate semconv in maven before removing #5849

Closed
jack-berg opened this issue Sep 21, 2023 · 1 comment
Labels
Feature Request Suggest an idea for this project

Comments

@jack-berg
Copy link
Member

Discussed #5807 in the 9/21/23 Java SIG and the possibility of using maven relocation to redirect users to the new coordinates before removing.

Investigate to determine if there is an increase in visibility to the user besides the deprecation notices that already exist.

@jack-berg jack-berg added the Feature Request Suggest an idea for this project label Sep 21, 2023
@jack-berg
Copy link
Member Author

Let's look at an example project which has used the maven relocation strategy:

  • org.hibernate:hibernate-core relocated to org.hibernate.org:hibernate-core as of version 6.0
  • New versions of the old group id org.hibernate:hibernate-core continue to be published with a POM (no jar) which includes the syntax to point to the new location. See this for example.
  • The new group id org.hibernate.org:hibernate-core has the full artifacts for 6.x+.
  • If I depend on org.hibernate:hibernate-core:5.6.15.Final and upgrade to org.hibernate:hibernate-core:6.0.0.Final, I don't get any sort of warning or error message, and I am silently upgraded to org.hibernate.org:hibernate-core:6.2.6.Final (new groupId, later version than what I thought I was getting).
  • If a depend on the now deprecated io.opentelemetry:opentelemetry-semconv, I get a compile message like: Note: /Users/jberg/code/example/src/main/java/com/jberg/Application.java uses or overrides a deprecated API. Note: Recompile with -Xlint:deprecation for details.

I don't think we should do maven relocation:

  • It requires ongoing published surface area
  • It silently upgrades to the new location and to surprising version (not the one I requested and also not the latest)
  • Its inconsistent with how we've handled location changes in the past for both experimental and stable artifacts
  • IMO, the value it provides isn't offset by the effort involved to develop the required tooling in this repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Suggest an idea for this project
Projects
None yet
Development

No branches or pull requests

1 participant