Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support zstd compression codec for open-telemetry/opentelemetry-java #5196

Closed
patrick-me opened this issue Feb 10, 2023 · 5 comments · Fixed by #6103
Closed

Support zstd compression codec for open-telemetry/opentelemetry-java #5196

patrick-me opened this issue Feb 10, 2023 · 5 comments · Fixed by #6103
Labels
Feature Request Suggest an idea for this project

Comments

@patrick-me
Copy link

Hi there!

Could you please, support zstd codec for the exporter or all of them.
ZSTD codec is much faster and more efficient than gzip, sure you know.

Btw, zstd is already supported by Collector

I'm looking forward to hearing from you
Thanks in advance

@patrick-me patrick-me added the Feature Request Suggest an idea for this project label Feb 10, 2023
@jack-berg
Copy link
Member

Do you have any thoughts on how this would be delivered, given that there isn't any native support in java?

There's a popular library called zstd-jni, but it looks like it packages up a architecture-dependent native library and has artifacts that are quite big, each on the order of 400kb. The main jar comprising all architectures is ~5.7mb.

Maybe we could provide an SPI to allow for bringing your own codec, and publish artifacts with some popular implementations. This would essentially allow users to opt-in to the big additional dependency.

Thoughts @jkwatson?

@jkwatson
Copy link
Contributor

"bring your own codec" seems fine, but maybe that's just "bring your own exporter and configure it however you like".

@jack-berg
Copy link
Member

open-telemetry/opentelemetry-java-contrib#1108 adds publishes a new artifact from contrib which adds support for zstd. Please take a look. Planning on closing this issue after #6103 is merged since we don't plan on adding support for other algorithms in this repo.

@patrick-me
Copy link
Author

Thank you very much, Jack 🙏

@jack-berg
Copy link
Member

Closing now that open-telemetry/opentelemetry-java-contrib#1108 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Suggest an idea for this project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants