Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK: Determine how to convert OpenTelemetry::Resources into Jaeger #486

Closed
jpkrohling opened this issue Aug 13, 2019 · 6 comments
Closed
Labels
priority:p2 Medium priority issues and bugs. release:required-for-ga Required for 1.0 GA release SDK

Comments

@jpkrohling
Copy link
Member

jpkrohling commented Aug 13, 2019

During the review for #481, the topic about converting OpenTelemetry Resources into Jaeger came up. Once it's clear what's to be done, the Adapter's toJaeger method needs to incorporate this conversion.

Context:
#481 (comment)

@pavolloffay pavolloffay changed the title Determine how to convert OpenTelemetry::Resources into Jaeger SDK: Determine how to convert OpenTelemetry::Resources into Jaeger Aug 15, 2019
@pavolloffay
Copy link
Member

The resource is set on only on tracer at the moment. We can treat it as process information which maps to Process struct in Jager. We could get the resource from the first span and merge it with the process created at exporter startup. We do the same in Jaeger client exporters.

@songy23
Copy link
Member

songy23 commented Sep 10, 2019

FYI in opentelemetry-service we translate resource into Jaeger process tags: open-telemetry/opentelemetry-collector#325.

@jkwatson jkwatson added the release:required-for-ga Required for 1.0 GA release label Jul 21, 2020
@jkwatson jkwatson added the priority:p2 Medium priority issues and bugs. label Aug 12, 2020
@thisthat
Copy link
Member

thisthat commented Sep 4, 2020

open-telemetry/opentelemetry-specification#848 has been resolved. Resources must be mapped to process tags: spec link.

@jkwatson
Copy link
Contributor

We should probably change the title of this issue to match the fact that it just needs to be implemented now. :)

@jkwatson jkwatson changed the title SDK: Determine how to convert OpenTelemetry::Resources into Jaeger SDK: Map OpenTelemetry::Resources into Jaeger process tags. Sep 14, 2020
@jkwatson
Copy link
Contributor

Aha. This is now a dupe of #1609 . I'll revert the title change for this issue and close it, now that the spec is done.

@jkwatson jkwatson changed the title SDK: Map OpenTelemetry::Resources into Jaeger process tags. SDK: Determine how to convert OpenTelemetry::Resources into Jaeger Sep 14, 2020
@jkwatson
Copy link
Contributor

Closing, now that the spec is complete and #1609 is ready to be implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:p2 Medium priority issues and bugs. release:required-for-ga Required for 1.0 GA release SDK
Projects
None yet
Development

No branches or pull requests

5 participants