Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ZipkinSpanExporter class public #1182

Closed
malafeev opened this issue May 7, 2020 · 3 comments · Fixed by #1186
Closed

Make ZipkinSpanExporter class public #1182

malafeev opened this issue May 7, 2020 · 3 comments · Fixed by #1186
Labels
Feature Request Suggest an idea for this project

Comments

@malafeev
Copy link
Contributor

malafeev commented May 7, 2020

Could you please provide info how to use non public class ZipkinSpanExporter?
Is it internal class not for usage by apps?
@malafeev malafeev added the Feature Request Suggest an idea for this project label May 7, 2020
@malafeev malafeev mentioned this issue May 7, 2020
Closed
@carlosalberto
Copy link
Contributor

It looks we should simply make it public. Any reason to not make ZipkinSpanExporter public @jkwatson ?

@jkwatson
Copy link
Contributor

jkwatson commented May 7, 2020

Not sure why it ended up non-public. It definitely should be publicly accessible.

@jkwatson jkwatson mentioned this issue May 7, 2020
Merged
@malafeev
Copy link
Contributor Author

malafeev commented May 8, 2020

thanks for fix, could you make a minor release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request Suggest an idea for this project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make the ZipkinSpanExporter public, so it can actually be used. newrelic-forks/opentelemetry-java
3 participants
@carlosalberto @jkwatson @malafeev