Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make micrometer bridge opt-in in 2.0 #9762

Closed
zeitlinger opened this issue Oct 26, 2023 · 0 comments · Fixed by #10038
Closed

make micrometer bridge opt-in in 2.0 #9762

zeitlinger opened this issue Oct 26, 2023 · 0 comments · Fixed by #10038
Assignees
@zeitlinger
Labels
enhancement New feature or request

Comments

@zeitlinger
Copy link
Member

Is your feature request related to a problem? Please describe.

  • Micrometer bridge duplicates a lot of metrics that are generated by the javaagent itself
  • The micrometer metrics also don't implement the semantic conventions (yet)
  • Inexperienced users can get confused when they browse available metrics

Describe the solution you'd like

Therefore, I suggest to make the bridge opt-in with 2.0.

A few metrics are only available with the micrometer bridge, so it's a rather niche use case.

Describe alternatives you've considered

No response

Additional context

No response
@zeitlinger zeitlinger added enhancement New feature or request needs triage New issue that requires triage labels Oct 26, 2023
@mateuszrzeszutek mateuszrzeszutek removed the needs triage New issue that requires triage label Oct 26, 2023
@zeitlinger zeitlinger self-assigned this Nov 28, 2023
@zeitlinger zeitlinger mentioned this issue Dec 8, 2023
Merged
@mateuszrzeszutek mateuszrzeszutek moved this from Todo to In Progress in Java Instrumentation 2.0 Dec 12, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Java Instrumentation 2.0 Dec 12, 2023
@laurit laurit mentioned this issue Aug 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zeitlinger zeitlinger

Labels
enhancement New feature or request
Projects
Java Instrumentation 2.0
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Breaking change: disable micrometer bridge by default zeitlinger/opentelemetry-java-instrumentation
2 participants
@zeitlinger @mateuszrzeszutek