Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Jetty 12 HTTP Client #9380

Closed
jorge-branco-dt opened this issue Sep 4, 2023 · 5 comments
Closed

Add support for Jetty 12 HTTP Client #9380

jorge-branco-dt opened this issue Sep 4, 2023 · 5 comments
Labels
contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome enhancement New feature or request new instrumentation

Comments

@jorge-branco-dt
Copy link

jorge-branco-dt commented Sep 4, 2023

Is your feature request related to a problem? Please describe.

We'd be looking for a solution similar to #2837 (Jetty 9 HTTP Client) but for Jetty 12, instead.
Unfortunately, Jetty 12 has gone through some serious API changes, and as such the previous instrumentation will definitely not work as it is.

Describe the solution you'd like

It seems the current Jetty 9.x implementation opted to instrument org.eclipse.jetty.client.HttpRequest.send(), which then calls org.eclipse.jetty.client.HttpClient,send(). HttpClient seems public so if I'm reading the situation correctly this may mean that calls to send() done directly through HttpClient may not currently be monitored..

On the other hand, in Jetty 12, HttpClient no longer seems to have a send() method, so one should indeed instrument org.eclipse.jetty.client.transport.HttpRequest.send(Response.CompleteListener) instead. Do note the change of package of HttpRequest, from org.eclipse.jetty.client to org.eclipse.jetty.client.transport.

Describe alternatives you've considered

No response

Additional context

No response

@jorge-branco-dt jorge-branco-dt added enhancement New feature or request needs triage New issue that requires triage labels Sep 4, 2023
@mateuszrzeszutek
Copy link
Member

Hey @jorge-branco-dt ,

We likely won't have time and resources to implement this instrumentation ourselves, but we would find an external contribution welcome.

@mateuszrzeszutek mateuszrzeszutek added contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome new instrumentation and removed needs triage New issue that requires triage labels Sep 4, 2023
@andythsu
Copy link

andythsu commented Feb 4, 2024

+1. @jorge-branco-dt Did you figure a way to instrument the client library in the meantime? or are you working on adding this?

@jorgedfbranco
Copy link

+1. @jorge-branco-dt Did you figure a way to instrument the client library in the meantime? or are you working on adding this?

Hi, unfortunately I won't have the time and it's not on our current roadmap.

@stevenschlansker
Copy link
Contributor

There's now initial support, this issue can probably be closed?

@steverao
Copy link
Contributor

support jettyclient 12 #11519

Sure, thank for your reminder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome enhancement New feature or request new instrumentation
Projects
None yet
Development

No branches or pull requests

6 participants