Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Micrometer metrics are exposed even if the instrumentation is disabled #8674

Closed
sakthiraam opened this issue Jun 8, 2023 · 0 comments · Fixed by #8677
Closed

Micrometer metrics are exposed even if the instrumentation is disabled #8674

sakthiraam opened this issue Jun 8, 2023 · 0 comments · Fixed by #8677
Labels
bug Something isn't working

Comments

@sakthiraam
Copy link

Describe the bug
We are seeing duplicated metrics when using OpenTelemetry agent. After doing some analysis it was found its because of the spring-boot-starter-actuator dependency in the application pom file.
We have explicitly set the otel.instrumentation.micrometer.enabled to false but even after that we can see the micrometer related metrics are getting exposed because of this HTTP metrics, runtime metrics etc are exposed twice. One set of time-series with semantics of Otel and another set with micrometer.

Steps to reproduce
Add the below dependency to your pom.xml file

		<dependency>
			<groupId>org.springframework.boot</groupId>
			<artifactId>spring-boot-starter-actuator</artifactId>
		</dependency>

Set the micrometer instrumentation to disabled
-Dotel.instrumentation.micrometer.enabled=false

What did you expect to see?
OTel should check the instrumentation state set (true/false) and should disable the instrumentation.

What did you see instead?
We are seeing the micrometer metrics getting exposed on top of OTel metrics.

What version are you using?
v.1.24.0 (distro)

Environment
OS: Windows & Linux
Runtime (if different from JDK above): OpenJDK 8,11,17
OS (if different from OS compiled on): Windows & Linux

Additional context
Currently we have set the management.metrics.enable.all=false to forcefully disable the metrics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant