Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GarbageCollector metrics gatherer should return a closeable similar to the other JMX gatherers #8475

Closed
roberttoyonaga opened this issue May 11, 2023 · 0 comments · Fixed by #8650
Closed

GarbageCollector metrics gatherer should return a closeable similar to the other JMX gatherers #8475

roberttoyonaga opened this issue May 11, 2023 · 0 comments · Fixed by #8650
Labels
enhancement New feature or request

Comments

@roberttoyonaga
Copy link
Contributor

Is your feature request related to a problem? Please describe.
This is not related to a problem.

Describe the solution you'd like
GarbageCollector metrics gatherer should return a closeable that unregisters its NotificationListener. This will make it similar to the other JMX metrics gatherers.

Additional context
This idea was mentioned here: #8165 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unregister jmx gc metrics laurit/opentelemetry-java-instrumentation
1 participant
@roberttoyonaga